The GitHub Actions job "Comment commands" on texera.git/main has succeeded. Run started by GitHub user eugenegujing (triggered by eugenegujing).
Head commit for run: 0ed48161419e5b4fa17bee10a17cdf2e43c28304 / yangzhang75 <[email protected]> fix(frontend): render the dashboard search page instead of crashing on the filters ViewChild getter (#6343) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> Fixes the blank dashboard search page reported in #6328. `SearchComponent` exposes its `FiltersComponent` child through a `@ViewChild` getter that throws until the view is initialized, and the template bound a search-results input directly to it (`[searchKeywords]="this.filters.getSearchKeywords()"`). Angular evaluates template expressions on the first change-detection pass — before the `@ViewChild` resolves — so the getter threw (`Property cannot be accessed before it is initialized`), aborting the component's render and leaving the results area blank. This binds the template to the already-initialized `searchKeywords` field (`[]` by default) and keeps it in sync in `search()`. The template no longer touches the throwing getter, so the page renders; keyword highlighting is unchanged. (2-line functional change.) ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234` or `Closes #1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> Closes #6328 ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> - New `search.component.spec.ts` (the component had no spec): 15 tests covering the render regression, the filters getter/setter, query-param handling, and `search()` / `filterByType` / `goBack` / `updateMasterFilterList`. - `yarn lint` clean. - Manually: `/dashboard/search` now renders results (previously blank). ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> Generated-by: Claude Code (Claude Opus 4.8) Co-authored-by: Claude Opus 4.8 <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/29172699658 With regards, GitHub Actions via GitBox
