The GitHub Actions job "Required Checks" on texera.git/main has failed. Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run: 10e7cb35000e68f6ab3a21348bba92886acd0152 / Meng Wang <[email protected]> test(frontend): extend AdminSettingsComponent coverage for save/reset handlers (#6527) ### What changes were proposed in this PR? Extends the existing `AdminSettingsComponent` spec (previously only `should create` + a template check, ~35% coverage) to cover the untested save/reset handlers. `AdminSettingsService`, `NzMessageService`, and `NotificationService` are stubbed; fake timers keep the handlers' `window.location.reload()` from firing under jsdom. 15 added tests cover: - `saveLogos` — persists only the branding assets that are set + success message; no-op when none set; error message on failure. - `resetBranding` — resets `logo` / `mini_logo` / `favicon`. - `saveTabs` / `resetTabs` — persist / reset every sidebar tab. - `saveDatasetSettings` — persists the four upload settings + success; rejects non-positive values; rejects a config that would exceed the 10,000-part limit (no save in either). - `resetDatasetSettings` — resets all four upload settings. - `saveCsvSettings` — persists the max-columns value + success; error on failure. - `resetCsvSettings` — resets the max-columns setting. - `onFileChange` — rejects a non-image file with an error; reads a valid image into the matching branding field. No production code was changed. ### Any related issues, documentation, discussions? Closes #6517 ### How was this PR tested? Extended unit tests, run locally in `frontend/` (all green; the failure path was verified by deliberately breaking an assertion to confirm the suite goes red): ``` ng test --watch=false --include src/app/dashboard/component/admin/settings/admin-settings.component.spec.ts # Test Files 1 passed (1) | Tests 17 passed (17) prettier --write <spec> # unchanged eslint <spec> # clean ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8 [1M context]) Report URL: https://github.com/apache/texera/actions/runs/29670740623 With regards, GitHub Actions via GitBox
