The GitHub Actions job "Backport Checks" on 
texera.git/fix/6977-stats-endpoint-auth has failed.
Run started by GitHub user Yicong-Huang (triggered by Yicong-Huang).

Head commit for run:
9c1fee648f17af5b0eaf25a3ee3b0ca7d07dae13 / mengw15 
<[email protected]>
fix(amber): require auth on retrieveWorkflowRuntimeStatistics

retrieveWorkflowRuntimeStatistics (GET /executions/{wid}/stats/{eid}) was
the only endpoint in WorkflowExecutionsResource declaring neither
@RolesAllowed nor an @Auth parameter, and the class has no class-level
annotation to fall back on -- auth is enforced per-method via
RolesAllowedDynamicFeature, so the handler was reachable without
authentication. Add @RolesAllowed(REGULAR, ADMIN) and an @Auth sessionUser
parameter, matching every sibling endpoint.

Add an auth-annotation audit test that reflects over the class's
@GET/@PUT/@POST/@DELETE handlers and asserts each declares @RolesAllowed
and takes an @Auth parameter, so a future endpoint added without auth turns
the suite red. exportResultToLocal is explicitly exempted: it serves a
browser form-submit download that cannot carry an Authorization header, so
its JWT arrives as a form field and is verified in-method via
JwtParser.parseToken, including the role check.

The frontend is unaffected: JwtModule attaches the Authorization header to
every request, and the same service already calls sibling endpoints that
require auth.

Closes #6977.

Report URL: https://github.com/apache/texera/actions/runs/30423913384

With regards,
GitHub Actions via GitBox

Reply via email to