This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-7192-050c226a6e9c605c1a9c6ae8adae9920af053def in repository https://gitbox.apache.org/repos/asf/texera.git
commit 18ebb0d1e6dded6f8bc04b7c52be4fa31cb27916 Author: Xinyuan Lin <[email protected]> AuthorDate: Fri Jul 31 23:26:59 2026 -0700 test(amber): cover computing unit worker args (#7192) ### What changes were proposed in this PR? Adds focused unit coverage for computing-unit worker command-line parsing, including empty input, repeated addresses, and malformed options. ### Any related issues, documentation, discussions? Closes #7189 ### How was this PR tested? - `WorkflowExecutionService/testOnly org.apache.texera.web.ComputingUnitWorkerSpec` — 5 passed. - `WorkflowExecutionService/Test/scalafmtAll` and `WorkflowExecutionService/Test/scalafix` - `WorkflowExecutionService/Test/scalafmtCheck` and `WorkflowExecutionService/Test/scalafix --check` Mutation proof (each production change was reverted): | Production mutation | Focused test result | | --- | --- | | Renamed the recognized `--serverAddr` option | 2 failed | | Changed the parsed option key | 2 failed | | Skipped malformed-option rejection | 2 failed | ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Codex (GPT-5) Co-authored-by: Meng Wang <[email protected]> --- .../texera/web/ComputingUnitWorkerSpec.scala | 59 ++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/amber/src/test/scala/org/apache/texera/web/ComputingUnitWorkerSpec.scala b/amber/src/test/scala/org/apache/texera/web/ComputingUnitWorkerSpec.scala new file mode 100644 index 0000000000..45ee3b7a3a --- /dev/null +++ b/amber/src/test/scala/org/apache/texera/web/ComputingUnitWorkerSpec.scala @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.web + +import org.apache.commons.jcs3.access.exception.InvalidArgumentException +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +class ComputingUnitWorkerSpec extends AnyFlatSpec with Matchers { + + "parseArgs" should "return no options when the worker receives no arguments" in { + ComputingUnitWorker.parseArgs(Array.empty[String]) shouldBe Map.empty + } + + it should "parse the worker server address without changing its value" in { + ComputingUnitWorker.parseArgs(Array("--serverAddr", "worker.internal:8090")) shouldBe + Map(Symbol("serverAddr") -> "worker.internal:8090") + } + + it should "use the last server address when the option is repeated" in { + ComputingUnitWorker.parseArgs( + Array("--serverAddr", "first:8080", "--serverAddr", "last:9090") + ) shouldBe + Map(Symbol("serverAddr") -> "last:9090") + } + + it should "reject an unknown command-line option" in { + val exception = intercept[InvalidArgumentException] { + ComputingUnitWorker.parseArgs(Array("--cluster", "true")) + } + + exception.getMessage shouldBe "unknown command-line arg" + } + + it should "reject a server address option with no value" in { + val exception = intercept[InvalidArgumentException] { + ComputingUnitWorker.parseArgs(Array("--serverAddr")) + } + + exception.getMessage shouldBe "unknown command-line arg" + } +}
