The GitHub Actions job "Backport Checks" on texera.git/test-ws-resource has succeeded. Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run: 253c0631458e80a7d31027005f5d6750c50e63a3 / Xinyuan Lin <[email protected]> test(amber): cover the websocket endpoint's request dispatch WorkflowWebsocketResource was at 0%. The endpoint is thin, but two parts of it are real logic nothing else guarded: - The write-access gate on WorkflowExecuteRequest. It is the only consumer of the privilege myOnOpen parses off the handshake, and it must both report to the client and rethrow. (Unreachable in single-node mode, where ServletAwareConfigurator hard-codes WRITE, but live under Kubernetes where the privilege comes from the x-user-computing-unit-access header.) - The catch-all error mapper, which stamps every failure as COMPILATION_ERROR with a placeholder operator and routes it to the socket when there is no execution. The test pins the nested shape of the scalapb enum, which serializes as an object rather than a string, so the client reads `type.name` -- flattening it would break the error panel silently. Six tests, driving a mocked javax.websocket.Session the way CollaborationResourceSpec does and registering a SessionState directly, so no real workflow is created. Each of the six was shown to fail under a targeted production mutation: neutering the access gate, dropping the "Initializing" announcement, swallowing the rethrow, closing the wrong session id, and answering a heartbeat with the wrong event. All reverted; the production diff is empty. Deliberately untested, each because it would pin an accidental failure rather than a contract: myOnOpen's missing-parameter and bogus-privilege paths; ModifyLogicRequest, whose reconfiguration service is null until executeWorkflow has run; and ResultPaginationRequest, whose no-workflow case is a discarded Option.foreach. Two findings recorded in comments rather than pinned. objectMapper .readValue sits outside the try, so an unparseable frame escapes un-mapped and the client is told nothing. And with a workflow attached but no execution, executionService.getValue returns null, so `workflowStateOpt.map(...)` yields Some(null), which slips past the `case None` guard and NPEs instead of raising the intended "execution is not initialized". Report URL: https://github.com/apache/texera/actions/runs/30880406984 With regards, GitHub Actions via GitBox
