The GitHub Actions job "Backport Checks" on 
texera.git/fix/text-input-offset-overflow has failed.
Run started by GitHub user Yicong-Huang (triggered by Yicong-Huang).

Head commit for run:
c0d82234c773e3f0b4a22721db5391d391eac1bf / eugenegujing 
<[email protected]>
fix(workflow-operator): text input operator using offset with an empty limit 
emits no rows

TextInputSourceOpExec computed its line window as slice(offset, offset + 
limit.getOrElse(Int.MaxValue)). With an offset set and the limit left empty, 
the addition overflows Int to a negative bound, which Iterator.slice clamps to 
0, so the operator silently emitted zero rows while the workflow reported 
success. An explicit large limit overflows the same way. This contradicts the 
Limit property's own description, "Leave empty to read all lines."

Replace the slice with drop(offset) + take(limit), the same idiom the CSV, 
Arrow, and JSONL scan sources already use. Every configuration that previously 
worked is unchanged.

Add regression tests covering offset-without-limit, offset with an Int.MaxValue 
limit, the offset+limit window, limit-only, offset at and past EOF, a negative 
offset, and SINGLE_STRING ignoring offset/limit.

Closes #7346

Co-Authored-By: Claude Fable 5 <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/31059252309

With regards,
GitHub Actions via GitBox

Reply via email to