The GitHub Actions job "Required Checks" on 
texera.git/gh-readonly-queue/main/pr-7396-ae3ad45c45712e22625a5e30516cc1a31df8c5de
 has succeeded.
Run started by GitHub user mengw15 (triggered by mengw15).

Head commit for run:
5914ae077fee211ba89af55ac7fea86bde2e0b72 / Kary Zheng 
<[email protected]>
feat(workflow-operator): stop forcing a color column on every Bubble Chart 
(#7396)

### What changes were proposed in this PR?

Bubble Chart's Color-Column was declared `required = true` with
`@NotNull`, but the generated Python reads it only inside the Enable
Color branch. The effect was that a freshly dropped Bubble Chart stayed
invalid until the user picked a color column, even when they wanted
plain bubbles — and the column they picked was then never used.

This PR makes the field optional and puts it behind the toggle via
`toggleHidden`, so it disappears from the panel when Enable Color is
off. That matches Ternary Plot, which has the same toggle-plus-column
pair and already declares its color field optional.

The color decision also moves out of the generated Python and into
Scala. The old template emitted an `if '...' == 'true':` comparison over
a Scala Boolean; it is now a `colorArg` computed at build time, guarded
on both the toggle and the column being non-empty. That second half
matters: with the required flag gone, an empty column would otherwise
reach `px.scatter(color='')`, which plotly rejects — the same failure
fixed for Bar Chart in #6792.

Behavior for existing workflows is unchanged. `enableColor` keeps its
meaning, so no saved chart changes appearance.

The operator reference page is updated to match the new requirement and
description.

### Any related issues, documentation, discussions?

Closes #7395

### How was this PR tested?

Existing `BubbleChartOpDescSpec` passes unchanged, including the
assertion that pins the no-color output line. Three cases were added to
it, covering the toggle-and-column matrix: enabled with a column chosen
(color is emitted), enabled with no column (color is omitted rather than
emitted empty), and disabled with a column chosen (the column is not
emitted).

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5)

Co-authored-by: Meng Wang <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/31343808670

With regards,
GitHub Actions via GitBox

Reply via email to