The GitHub Actions job "Required Checks" on texera.git/fix-clear-text-property has succeeded. Run started by GitHub user kz930 (triggered by kz930).
Head commit for run: c6f9c7c95e60e8365798b27a59d9f15e12a9f337 / kary zheng <[email protected]> feat(frontend): remove an operator property when its field is cleared Clearing a text or number field in the property panel left the box empty on screen while the operator kept the value it held before, so the workflow ran on a value the user had removed and could no longer see. Setting CSV File Scan's Limit to 5 and clearing it left the scan reading 5 rows, with nothing on screen saying so; the value came back on the next reload. The panel is not at fault. It sends the properties it has, and a cleared field is simply not among them: formly drops a cleared text field from the model outright, and a cleared number arrives as null, which onFormChanges filters out. Either way the properties reaching the shared model no longer carry that key. updateYTypeFromObject had no way to act on that. It walks the union of old and new keys and, for each, updates a value in place or sets a new one. For a key the new object no longer carries it did neither: the in-place update refuses an undefined value, and the set that follows is guarded on the value not being undefined. The old entry stayed in the Y.Map, and a removal could not be expressed at all. It now deletes such a key. Membership decides, not the value: a key carried with an explicit undefined still takes the update path, and only a key that is gone is a removal. The test that pinned the old behaviour is updated rather than removed, since it described what the function did rather than what it should do, and setOperatorProperty gains the case that fails without this change. Clearing now does what the panel shows. A property with a schema default comes back as that default when the panel is next rendered, which is one of the two behaviours the issue asks for; one without a default stays empty. Closes #7394 Generated-by: Claude Code (Claude Opus 5) Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/31551065751 With regards, GitHub Actions via GitBox
