The GitHub Actions job "Required Checks" on texera.git/main has succeeded.
Run started by GitHub user github-merge-queue[bot] (triggered by 
github-merge-queue[bot]).

Head commit for run:
444fc582840cbac7a6fe3479fd3890dd6efe9549 / Tanishq Gandhi 
<[email protected]>
refactor(amber): make the hub and unified search resource-agnostic (#7928)

### What changes were proposed in this PR?

The hub dispatched on `EntityType` in four separate places, and
`DatasetSearchQueryBuilder`
carried its own copy of the access-scoped join, the keyword/date/id
filter and the
LakeFS-sized hydration. Adding a second resource type meant four
dispatch edits plus a
clone of the query logic, and two of those sites compiled cleanly but
failed at runtime.

- `EntityTables` now exposes one `EntityTableSet` per entity type, with
`cloneTable` as an
`Option` and a new `AccessTable` that removes the non-exhaustive match
in
  `HubResource.userAccess`.
- `VersionedResourceTables` names the columns of a LakeFS-backed
resource;
`VersionedResourceSearchQueryBuilder` holds the single copy of FROM /
WHERE / hydration.
  `DatasetSearchQueryBuilder` keeps only its projection.
- The five dataset-only slots in `UnifiedResourceSchema` become shared
versioned-resource
slots, so the next resource type widens the union by two columns instead
of seven.

Two existing bugs are fixed as a result: `getTops?entityType=dataset`
with no `actionTypes`
no longer 500s on a throwing `CloneTable(Dataset)`, and `getCounts`'
clone guard now asks
whether the entity type has a clone table instead of whether it is not a
dataset.

No user-facing behavior changes.

### Any related issues, documentation, discussions?

Prepares the amber side of #6501 (part of #6494): adding models becomes
one descriptor plus
one registry entry. Contains #6872 and #7922, so their commits show in
the diff until they
merge.

### How was this PR tested?

Existing suites, unmodified except where they pin the renamed projection
aliases:
`WorkflowExecutionService/testOnly *dashboard*` — 467/467, and
`FileService/test` — 376/376.
New `VersionedResourceTablesSpec` covers the descriptor contract and the
access-join
predicate; `EntityTablesSpec` covers the registry; regression tests
added for the two bugs
above (`getTops` with no `actionTypes`, and the clone bucket for a
cloneless entity type).

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5)

Report URL: https://github.com/apache/texera/actions/runs/32996128997

With regards,
GitHub Actions via GitBox

Reply via email to