This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new 5dd43cfe9f chore(build): remove the dead -Xelide-below scalac option
(#7709)
5dd43cfe9f is described below
commit 5dd43cfe9f68f80589e26d41d4767989f86e9f35
Author: Xinyuan Lin <[email protected]>
AuthorDate: Sat Aug 29 06:33:26 2026 +0000
chore(build): remove the dead -Xelide-below scalac option (#7709)
### What changes were proposed in this PR?
Removes `-Xelide-below WARNING` from the sixteen `build.sbt` files that
set it, along with the comments that exist only to explain it.
Build-config only, **16 files, −20 lines**, no behaviour change.
> ⚠️ **Stacked on #7451.** The first commit here is #7451's deletion of
`ElidableStatement`; it drops out of this diff once #7451 merges. The
order is required — see *Why the order matters* below. Review the second
commit, `chore(build): remove the dead -Xelide-below scalac option`.
#### Why the flag is dead
`-Xelide-below <level>` makes scalac replace a call to an `@elidable(n)`
method with `()` when `n < level`. The only `@elidable`-annotated code
in this repo was `ElidableStatement`:
| Wrapper | Level | vs. `WARNING` (900) |
| --- | ---: | --- |
| `finest` | `FINEST` 300 | compiled out |
| `finer` | `FINER` 400 | compiled out |
| `fine` | `FINE` 500 | compiled out |
| `info` | `INFO` 800 | compiled out |
It had no callers, so nothing was actually being elided, and #7451
deletes it. After that `git grep -in elidable` is empty and the flag
switches nothing.
#### Why this is a no-op, not a silent re-enable
The obvious worry is `assert`. It is `@elidable(ASSERTION)` = **2000**,
above `WARNING`, so assertions are compiled in today — and scalac's
default with `-Xelide-below` absent elides nothing, so they are compiled
in after this too. Same for `assume`. Nothing that was elided starts
running, and nothing that was running stops.
#### Why the order matters
Dropping the flag while `ElidableStatement` still exists would break
`ElidableStatementSpec`, which asserts `counter == 0` after
`ElidableStatement.info { counter += 1 }` — true only under elision.
Hence the stack rather than a standalone PR.
#### What was removed
Thirteen modules share one line; three differ:
| File | Removed |
| --- | --- |
| `amber/build.sbt` | the whole `scalacOptions ++= Seq(...)` line + the
`// to turn on, use: INFO` / `// to turn off, use: WARNING` pair above
it |
| `common/workflow-compiler/build.sbt` | two `Seq` entries (flag and
value on separate lines) |
| `computing-unit-managing-service/build.sbt` | one `Seq` entry |
| the other thirteen | one `Seq` entry each, with its `// Turn on
optimizations with "WARNING" as the threshold` trailing comment |
Full list: `access-control-service`, `amber`,
`common/{auth,config,dao,pybuilder,resource,util,workflow-compiler,workflow-core,workflow-operator}`,
`computing-unit-managing-service`, `config-service`, `file-service`,
`notebook-migration-service`, `workflow-compiling-service`.
### Any related issues, documentation, discussions?
Closes #7706
Follow-up to a review note from @Yicong-Huang on #7451.
### How was this PR tested?
Existing tests only — this is a build-config removal, and there is
nothing left to test once the one construct the flag governed is gone.
Locally, from the repo root with Java 17:
- `sbt compile Test/compile` over the root aggregate (all sixteen
modules) — success.
Verification, re-runnable by a reviewer:
```
git grep -in xelide # nothing
git grep -in elidable # nothing
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
---
access-control-service/build.sbt | 1 -
amber/build.sbt | 4 ----
common/auth/build.sbt | 1 -
common/config/build.sbt | 1 -
common/dao/build.sbt | 1 -
common/pybuilder/build.sbt | 1 -
common/resource/build.sbt | 1 -
common/util/build.sbt | 1 -
common/workflow-compiler/build.sbt | 2 --
common/workflow-core/build.sbt | 1 -
common/workflow-operator/build.sbt | 1 -
computing-unit-managing-service/build.sbt | 1 -
config-service/build.sbt | 1 -
file-service/build.sbt | 1 -
notebook-migration-service/build.sbt | 1 -
workflow-compiling-service/build.sbt | 1 -
16 files changed, 20 deletions(-)
diff --git a/access-control-service/build.sbt b/access-control-service/build.sbt
index 48c63d2148..93af38e442 100644
--- a/access-control-service/build.sbt
+++ b/access-control-service/build.sbt
@@ -48,7 +48,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/amber/build.sbt b/amber/build.sbt
index b1f8a0d481..f4915589e7 100644
--- a/amber/build.sbt
+++ b/amber/build.sbt
@@ -35,10 +35,6 @@ Universal / mappings := AddMetaInfLicenseFiles.distMappings(
semanticdbEnabled := true
semanticdbVersion := scalafixSemanticdb.revision
-// to turn on, use: INFO
-// to turn off, use: WARNING
-scalacOptions ++= Seq("-Xelide-below", "WARNING")
-
// to check feature warnings
scalacOptions += "-feature"
// to check deprecation warnings
diff --git a/common/auth/build.sbt b/common/auth/build.sbt
index 4f325bf77e..866babec95 100644
--- a/common/auth/build.sbt
+++ b/common/auth/build.sbt
@@ -41,7 +41,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/common/config/build.sbt b/common/config/build.sbt
index f6a8aa0568..e1b8c5a1e1 100644
--- a/common/config/build.sbt
+++ b/common/config/build.sbt
@@ -38,7 +38,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/common/dao/build.sbt b/common/dao/build.sbt
index 8bc49072d2..d010ebd40c 100644
--- a/common/dao/build.sbt
+++ b/common/dao/build.sbt
@@ -114,7 +114,6 @@ Compile / sourceGenerators += jooqGenerate
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/common/pybuilder/build.sbt b/common/pybuilder/build.sbt
index aeec3f2722..cf6bf9fb26 100644
--- a/common/pybuilder/build.sbt
+++ b/common/pybuilder/build.sbt
@@ -42,7 +42,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/common/resource/build.sbt b/common/resource/build.sbt
index 53d2370614..ab97460155 100644
--- a/common/resource/build.sbt
+++ b/common/resource/build.sbt
@@ -38,7 +38,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/common/util/build.sbt b/common/util/build.sbt
index 0f4446edcc..addb2ff9fd 100644
--- a/common/util/build.sbt
+++ b/common/util/build.sbt
@@ -37,7 +37,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/common/workflow-compiler/build.sbt
b/common/workflow-compiler/build.sbt
index d8d7aea89c..b522452966 100644
--- a/common/workflow-compiler/build.sbt
+++ b/common/workflow-compiler/build.sbt
@@ -26,8 +26,6 @@ scalacOptions += "-Ymacro-annotations"
// Scala compiler options (mirrors the other common modules;
`-Ywarn-unused:imports`
// is required by the scalafix RemoveUnused rule that CI runs via scalafixAll).
Compile / scalacOptions ++= Seq(
- "-Xelide-below",
- "WARNING",
"-feature",
"-deprecation",
"-Ywarn-unused:imports"
diff --git a/common/workflow-core/build.sbt b/common/workflow-core/build.sbt
index 0d48fc4048..bfc1467041 100644
--- a/common/workflow-core/build.sbt
+++ b/common/workflow-core/build.sbt
@@ -80,7 +80,6 @@ Test / testGrouping := {
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/common/workflow-operator/build.sbt
b/common/workflow-operator/build.sbt
index 2bb41754a5..7fb262cda5 100644
--- a/common/workflow-operator/build.sbt
+++ b/common/workflow-operator/build.sbt
@@ -55,7 +55,6 @@ Test / testOptions ++= TestFilters.integrationSplit(
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/computing-unit-managing-service/build.sbt
b/computing-unit-managing-service/build.sbt
index 952544a6d0..04c403687e 100644
--- a/computing-unit-managing-service/build.sbt
+++ b/computing-unit-managing-service/build.sbt
@@ -56,7 +56,6 @@ libraryDependencies ++= Seq(
// Compiler Options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING",
"-feature",
"-deprecation",
"-Ywarn-unused:imports"
diff --git a/config-service/build.sbt b/config-service/build.sbt
index a7f85badef..de3e034852 100644
--- a/config-service/build.sbt
+++ b/config-service/build.sbt
@@ -48,7 +48,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/file-service/build.sbt b/file-service/build.sbt
index 3e557383b7..defbb99c1f 100644
--- a/file-service/build.sbt
+++ b/file-service/build.sbt
@@ -48,7 +48,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/notebook-migration-service/build.sbt
b/notebook-migration-service/build.sbt
index 53dc3c9e31..e907d977f1 100644
--- a/notebook-migration-service/build.sbt
+++ b/notebook-migration-service/build.sbt
@@ -48,7 +48,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
diff --git a/workflow-compiling-service/build.sbt
b/workflow-compiling-service/build.sbt
index 96fb874a7d..2af92efc4d 100644
--- a/workflow-compiling-service/build.sbt
+++ b/workflow-compiling-service/build.sbt
@@ -50,7 +50,6 @@ Global / concurrentRestrictions += Tags.limit(Tags.Test, 1)
// Scala compiler options
Compile / scalacOptions ++= Seq(
- "-Xelide-below", "WARNING", // Turn on optimizations with "WARNING" as
the threshold
"-feature", // Check feature warnings
"-deprecation", // Check deprecation warnings
"-Ywarn-unused:imports" // Check for unused imports
