The GitHub Actions job "Required Checks" on 
texera.git/ci/8084-backport-manager-approval-gate has failed.
Run started by GitHub user mengw15 (triggered by mengw15).

Head commit for run:
77d573c1a25ddf0252ae87a1a0c16c06bb3ebc29 / mengw15 
<[email protected]>
ci: scope the approvals context to main, and report the veto contradiction

Review findings on the previous head, all four verified before fixing:

  - `Backport Approvals` was added to the Merge Queue ruleset, which also
    covers release/v1.1, v1.2 and v1.3. The workflow exists only on the
    default branch and a `pull_request` run takes its workflows from the
    merge ref, so on those branches the context has no producer and never
    appears — 17 open PRs into release/v1.2, nearly all draft backports
    this pipeline opened, would have waited on it forever. It also has
    nothing to say there: a PR already targeting a release branch is
    itself a backport and reports success. Moved to its own ruleset
    scoped to ~DEFAULT_BRANCH.

  - `no-backport-needed` emptied the target list, so the check passed
    while the `release/*` labels stayed on: nothing anywhere removes
    them, and precheck documents adding the veto mid-review, by which
    point the auto-labeler has applied them. The PR then merged carrying
    a label promising a backport the push skips — the false record this
    check exists to prevent. The contradiction is now reported, naming
    both ways to resolve it, rather than settled silently in the veto's
    favour.

  - The composition paragraph in release-branches.yml still described the
    design this replaced: an approval landing the fix on v1.2 while v1.3
    is left behind cannot happen once the merge waits for every label.

  - The `actively-supporting` paragraph claimed an inactive branch's
    manual label makes the backport "run as usual". It no longer does:
    that manager must approve before the PR can merge, and no review is
    requested for an inactive branch, so nobody is told to.

The `declined` and files-absent `skipped` rows still told a maintainer
that adding a label is what causes the backport; both now say the
manager's approval is also required.

Report URL: https://github.com/apache/texera/actions/runs/33710669719

With regards,
GitHub Actions via GitBox

Reply via email to