The GitHub Actions job "Required Checks" on 
texera.git/fix/resource-size-rendering has succeeded.
Run started by GitHub user tanishqgandhi1908 (triggered by tanishqgandhi1908).

Head commit for run:
cee78ca047af9a185eb882a1b7b4f571d0e81ea9 / Tanishq Gandhi 
<[email protected]>
feat(frontend): render an absent fact as an em dash and a size as 0 B everywhere

A resource's size, and the facts it has none of, rendered four different ways
depending on where you looked. This settles on one convention: a fact with
nothing to show renders an em dash, and a size renders 0 B, because zero bytes
is a meaningful answer.

Card view hid the size row behind *ngIf="size", so a dataset created but never
uploaded to showed no size line at all in card view and "Size: 0 B" in list
view. Card view now always renders the row.

Only search asks the backend for workflow sizes, so a DashboardEntry built
straight from a duplicate response carried no size and a freshly copied
workflow claimed 0 B beside correctly-sized siblings. Both duplicate paths now
fetch the sizes before the rows go on screen; the list items read the size once
on binding, so filling it in afterwards would not show.

The two detail cards also disagreed with each other: the dataset Data Card left
"Last updated" and "Latest version file" blank, while the model Model Card
em-dashed them and its size. Both pages now em-dash the version facts and both
render 0 B for the size.

formatSize is deliberately unchanged.

Closes #8380.

Report URL: https://github.com/apache/texera/actions/runs/33812315125

With regards,
GitHub Actions via GitBox

Reply via email to