The GitHub Actions job "Benchmarks" on texera.git/fix/owner-filter-scope has 
succeeded.
Run started by GitHub user Yicong-Huang (triggered by Yicong-Huang).

Head commit for run:
146a35059aa9eec66080ae4080f9396ffc8db4db / Tanishq Gandhi 
<[email protected]>
feat(frontend, amber): offer the owners of what each page actually shows

The Owner dropdown should list the people who own the things on the page. On
the unified search page and on the hub it did not.

The search page rendered <texera-filters> with no [entityType], so the bar kept
its EntityType.Workflow default on every tab: the Dataset, Model and All tabs
all offered workflow owners, and ticking one emptied the tab. Separately,
nothing could ask who owns the published entries -- all three *-owners
endpoints filter on the caller's own access rows, which is right for the Your
Work pages and wrong for the hub, where the dropdown offered people whose
resources are not on the page and omitted the people whose resources are.

Backend: one endpoint rather than three. HubResource.getCount already runs
where(isPublicColumn.eq(true)) over a per-kind registry covering workflows,
datasets and models, so GET /hub/owners is its sibling. BaseEntityTable gains
joinWithOwner, implemented once in VersionedResourceTables for dataset and
model. It is deliberately not joinWithAccessAndOwner(None), which left-joins
the access table and fans out a row per grant. The existing *-owners endpoints
are untouched.

Frontend: FiltersComponent gains an ownerScope input and accepts a null
entityType for a page listing every kind, and ResourceRegistryService.ownersFor
resolves which lists to ask for -- the access-scoped endpoint for Your Work,
the new one for the hub, and both merged for unified search, which lists both.
The bar now implements OnChanges so switching tabs refetches, through a
switchMap so a fast run of clicks cannot let a stale response land last.

Signed-out visitors still get no Owner dropdown: the list is email addresses,
so the new endpoint is @RolesAllowed like its siblings.

Closes #8385.

Report URL: https://github.com/apache/texera/actions/runs/33909679383

With regards,
GitHub Actions via GitBox

Reply via email to