The GitHub Actions job "Backport Approval Check" on texera.git/fix/operator-suite-handle-leak has failed. Run started by GitHub user mengw15 (triggered by mengw15).
Head commit for run: c811d7b3a5ec35cd27705e85d66b980363873061 / Xinyuan Lin <[email protected]> fix(test): make the LARGE_BINARY scan test able to fail `"create LargeBinary when reading file with LARGE_BINARY type"` wrapped its whole body in `catch { case e: Exception => info(...) }`. ScalaTest's `assert` throws `TestFailedException`, which extends `Exception`, so every assertion inside the try was swallowed and reported only through `info(...)` -- which the `-u`-only reporter this build configures does not surface. The test could not fail for any reason. What it was really tolerating is the environment, in two places: no large-binary base URI is bound to the test thread, and `LargeBinaryOutputStream.close()` uploads to S3, which this module's test scope has no endpoint for. So handle both explicitly instead of catching everything: - Seed the thread's base URI the way the coordinator does in production (and `LargeBinaryManagerSpec` does in test), clearing it afterwards, so an unset base URI can no longer be mistaken for the operator misbehaving. - Probe S3 reachability up front and `cancel` when it is absent, leaving the scan itself uncaught -- a catch around the scan would still report a genuine operator failure as a skip. - Move the assertions outside the try so their failures propagate. The drain added for the handle leak stays, and now also drops a throw of its own so it cannot displace an in-flight failure -- the failure path it guards is reachable for the first time now that the test can fail. Verified by mutation: with `s3://` changed to `gs://` the test fails (1 TEST FAILED, exit 1) where before it passed. Docker is unavailable here, so the assertions were exercised against a stub S3 endpoint driven through a temporary subclass of this spec: 7 succeeded, 0 canceled, with the stub observing the real multipart sequence and the file's bytes. Without an endpoint: 6 succeeded, 1 canceled, 0 aborted. Full `WorkflowOperator/test`: 290 suites, 0 aborted, 2300 succeeded, 1 canceled. Report URL: https://github.com/apache/texera/actions/runs/34733549465 With regards, GitHub Actions via GitBox
