This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new d234fad20b feat(config): turn the Form View on by default (#8528)
d234fad20b is described below
commit d234fad20bbbdce29031ab74707297927ecae433
Author: yangzhang75 <[email protected]>
AuthorDate: Tue Sep 15 23:10:01 2026 +0000
feat(config): turn the Form View on by default (#8528)
### What changes were proposed in this PR?
Closes #8537. The closing PR of the Form View stack (parent issue
#8011). Every piece of the feature has landed behind `form-view-enabled
= false`; this flips the default to true, with the GuiConfigSpec
assertion updated to match. Nothing else changes. A deployment that
wants the feature off sets
`GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED=false`, which the config
already reads.
On main now that #8456 (the entry points) has merged; the branch's
single commit is the whole change.
### Any related issues, documentation, discussions?
Closes #8537. Part of the Form View feature (parent issue #8011).
### How was this PR tested?
GuiConfigSpec asserts the new default. The frontend specs that exercise
the entry points already run with the flag on (the shared config mock
defaults it off and each such spec enables it), so they are unaffected
by the default.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Code.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01FVvP3ttj22f9LB4p9u2anY
Co-authored-by: Claude Fable 5.1 <[email protected]>
Co-authored-by: Meng Wang <[email protected]>
---
common/config/src/main/resources/gui.conf | 2 +-
.../test/scala/org/apache/texera/common/config/GuiConfigSpec.scala | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/config/src/main/resources/gui.conf
b/common/config/src/main/resources/gui.conf
index cccfe4a7d2..7cb7fff655 100644
--- a/common/config/src/main/resources/gui.conf
+++ b/common/config/src/main/resources/gui.conf
@@ -92,7 +92,7 @@ gui {
timetravel-enabled = ${?GUI_WORKFLOW_WORKSPACE_TIMETRAVEL_ENABLED}
# whether the Form View (a second, form-based view of a workflow) is
enabled
- form-view-enabled = false
+ form-view-enabled = true
form-view-enabled = ${?GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED}
# Whether to connect to local or production shared editing server. Set to
true if you have
diff --git
a/common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala
b/common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala
index e3d98d261a..cfc978de3a 100644
---
a/common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala
+++
b/common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala
@@ -62,9 +62,9 @@ class GuiConfigSpec extends AnyFlatSpec with Matchers {
ifUnset("GUI_WORKFLOW_WORKSPACE_TIMETRAVEL_ENABLED")(
GuiConfig.guiWorkflowWorkspaceTimetravelEnabled shouldBe false
)
- // Form View ships disabled so merging the feature never turns it on; the
final PR flips it.
+ // Form View is on by default now that the whole feature has landed.
ifUnset("GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED")(
- GuiConfig.guiWorkflowWorkspaceFormViewEnabled shouldBe false
+ GuiConfig.guiWorkflowWorkspaceFormViewEnabled shouldBe true
)
ifUnset("GUI_WORKFLOW_WORKSPACE_PRODUCTION_SHARED_EDITING_SERVER")(
GuiConfig.guiWorkflowWorkspaceProductionSharedEditingServer shouldBe
false
