The GitHub Actions job "Release Auditing" on 
texera.git/backport/8060-source-filter-owners-per-resource-kind-a-v1.2 has 
failed.
Run started by GitHub user github-actions[bot] (triggered by 
github-actions[bot]).

Head commit for run:
c7d3fa4035d767d302296313b6130a9cf6f2e7dc / Tanishq Gandhi 
<[email protected]>
fix(frontend, amber): source filter owners per resource kind and apply them to 
datasets (#8060)

### What changes were proposed in this PR?

The Owner filter on the Datasets pages was broken on both sides:

1. **Wrong list.** `<texera-filters>` always read its Owner and ID
dropdowns from `WorkflowPersistService`, so Datasets listed workflow
owners and offered a workflow-ID filter.
2. **No effect.** `VersionedResourceSearchQueryBuilder` applied the
date, id and full-text filters but dropped `params.owners`, so selecting
an owner changed nothing.

```
Before:  Datasets -> filters -> workflowPersistService.retrieveOwners()  -> 
workflow owners
         owner=<email> -> VersionedResourceSearchQueryBuilder            -> 
ignored

After:   Datasets -> filters -> datasetService.retrieveOwners()          -> 
dataset owners
         owner=<email> -> VersionedResourceSearchQueryBuilder            -> 
USER.EMAIL predicate
```
Before -
<img width="1239" height="533" alt="Screenshot 2026-08-27 at 3 36 49 PM"
src="https://github.com/user-attachments/assets/ca1f0055-17d3-46cb-b4c8-65a1005bec5f";
/>

After -
<img width="1227" height="598" alt="Screenshot 2026-08-27 at 4 41 05 PM"
src="https://github.com/user-attachments/assets/294335e6-6028-44c2-af46-c2ad19781c97";
/>

- `filters.component.ts` gains `@Input() entityType`, defaulting to
`Workflow`, so the Workflows and
  unified search pages are untouched.
- `VersionedResourceSearchQueryBuilder` adds the
`getContainsFilter(params.owners, USER.EMAIL)` the
workflow builder already uses. The `USER` join was already in the FROM
clause.
- The id dropdown hides where no id endpoint exists. Adding
`/dataset/user-dataset-ids` and
  `/model/user-model-ids` is left to a follow-up feature.

### Any related issues, documentation, discussions?

Closes #8059.

### How was this PR tested?

Five new tests in `filters.component.spec.ts` (owners per kind, ids only
for workflows, dropdown
hidden for datasets) and three in `DatasetSearchQueryBuilderSpec` (one
owner renders the predicate,
several OR together but AND with the id filter, none renders nothing).

```bash
cd frontend && npx ng test $(grep -rl "FiltersComponent\|DatasetService" 
src/app | grep "spec.ts$" | sed 's/^/--include /' | tr '\n' ' ')
sbt 'testOnly *DatasetSearchQueryBuilderSpec'
```

909 frontend tests, 21 backend, all passing. Plus `tsc --noEmit`,
eslint, prettier, `scalafmtCheck`.

Manual: signed in as a user with a shared dataset plus their own
workflow, the Datasets page now
lists only the dataset's owner, ticking it narrows the list, and the id
dropdown is gone. Workflows
page unchanged.

### Was this PR authored or co-authored using generative AI tooling?

(backported from commit eddec267a2c6974d0ea0f29b63e9c7506e12f9b4)

Generated-by: Claude Code Opus 5

Report URL: https://github.com/apache/texera/actions/runs/33130522774

With regards,
GitHub Actions via GitBox

Reply via email to