The GitHub Actions job "Backport Approval Check" on 
texera.git/feat/7751-require-warehouse-v2 has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
d709eada380f26241dbe2164804106f4005e9a6d / mengw15 
<[email protected]>
fix: validate the pick on the sync path too, and let an absent pick clear

Three gaps the review found in the previous round's fixes:

The sync endpoint shuts the previous execution down itself, before
initExecutionService ever runs, so the agent path still took the
execution in flight down with a request it was going to refuse. It now
resolves the pick before that shutdown.

WorkflowServiceSpec still asserted the old contract — that a refused
request detaches the previous execution — so it failed against the new
ordering. It now asserts the opposite, and a new case pins the ordering
for the warehouse check itself (the uid case alone could not: it already
threw before the teardown).

An omitted warehouseId left the agent's previous pick in place, so a
cleared selection kept sending a stale id, refused as an explicit pick
once the feature is off. An absent field is now the selection it
represents: none.

Report URL: https://github.com/apache/texera/actions/runs/35386820932

With regards,
GitHub Actions via GitBox

Reply via email to