The GitHub Actions job "Benchmarks" on 
texera.git/feat/verify-compare-two-answers has succeeded.
Run started by GitHub user kz930 (triggered by kz930).

Head commit for run:
b17651befe6714594010667e9c6fd928127b06a4 / kary zheng <[email protected]>
fix(verify): compare what the two sides actually wrote

Five ways the comparison agreed with itself rather than with the outputs.

The column list was never checked. The comparison took its columns from the
actual side and selected those out of the expected one, so a column only the
expected side carried was never looked at, and `check_like` sorted the columns
before comparing, so a reordering passed. Column order decides what a positional
UDF reads, what a file export writes, and what code asking for the first column
gets, so both halves of the list are compared now.

A boolean setting in a Plotly figure fell into the numeric branch, `bool` being
a subclass of `int` in Python, and True compared equal to 1 through isclose. A
column whose declared type changed from boolean to integer reaches a figure as
exactly that difference.

A model was asked about its own fitted feature names. Two models fitted on
different columns still answer alike on a probe carrying both, so the
predictions agreed while the models did not. The names are compared first.

A column the schema declares as text was read with `dtype=str`, which settles
the two sides on one spelling but turns the JSON number 6 into "6" as readily as
it leaves "6" alone. Those columns are re-read from the raw JSON, where a number
is still a number.

An integer column one side widened to a float passed as the integer the schema
asked for. 6 and 6.0 do not survive the same: a later cast to text writes "6"
from one and "6.0" from the other. Both sides widening alike is left alone,
because where the engine's own path is a Python operator its table goes through
pandas too, and the two still agree. A declared boolean column is read the same
way, numpy having counted True as 1 under a comparison told not to check dtypes.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/35404859870

With regards,
GitHub Actions via GitBox

Reply via email to