The GitHub Actions job "Required Checks" on 
texera.git/test/6684-combine-validation has succeeded.
Run started by GitHub user suyashj1231 (triggered by suyashj1231).

Head commit for run:
2ec903987e29a666b0eb029775bb2e72021064d2 / suyashj1231 
<[email protected]>
test(validation): cover ValidationWorkflowService.combineValidation

combineValidation is what turns per-check results into the single
verdict the workflow editor acts on, and it had no direct test.

The cases pin down the three things the implementation decides:

  - validity is an AND across all validations, order-independent
  - messages are merged only from the validations that failed, so a
    stray `messages` on something reporting isValid: true is dropped
  - a later failure wins when two failures use the same message key

Two shape details are asserted too, since call sites depend on them: the
valid result omits `messages` entirely rather than returning an empty
map, and the no-argument call is vacuously valid.

Closes #6684

Claude-Session: https://claude.ai/code/session_01EeaEYRdhRYWL7ya7w8LJux

Report URL: https://github.com/apache/texera/actions/runs/35410524788

With regards,
GitHub Actions via GitBox

Reply via email to