The GitHub Actions job "Backport Approval Check" on 
texera.git/fix/8606-editor-container has failed.
Run started by GitHub user yangzhang75 (triggered by yangzhang75).

Head commit for run:
a0eb5687a0bc021c159790bb77ca6aa68c9437d9 / Yang Zhang <[email protected]>
fix(frontend): give the workflow editor its own container, not the document's 
first

Found in the browser: switching to the Form View and back left the canvas
blank -- nothing to pan, nothing to click -- while the graph itself was
fine, as the Form View's preview went on showing it running.

`WorkflowEditorComponent` found its container with
`document.getElementById("workflow-editor")`, and both views render that
same hardcoded id: the canvas's editor and the Form View's preview are
the same component. While the switch was a full page load the two could
never coexist, so the lookup was always right. Routing between the views
overlaps them for a tick -- the arriving view runs `ngAfterViewInit`
while the departing one is still in the DOM -- and a document-wide
lookup then returns the departing view's container, first in document
order. The paper was built into a div about to be removed, and the
arriving canvas kept an empty one.

Measured in a real browser, at the moment the canvas comes back:

  [GETBYID] workflow-editor: 2 in document, returned index 0
  before: #workflow-editor 1399x1000, svg=false, cells=0
  after:  #workflow-editor 1399x1000, svg=true,  cells=1

It resolves both elements from its own host now. No run is needed to
reproduce; expanding the Form View's preview once is enough, which is
why watching a run there made it certain.

Deletion-checked: restoring the document-wide lookup turns exactly the
new named test red.

Full frontend suite: 224 files, 6150 passed, 1 skipped, 0 failed. AOT
build, eslint and prettier clean.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01FVvP3ttj22f9LB4p9u2anY

Report URL: https://github.com/apache/texera/actions/runs/35422313639

With regards,
GitHub Actions via GitBox

Reply via email to