The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-8397-896426c40325f8664e1e1015cf759c6aadc66799 has failed. Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run: c49c9c3007d04fd6e6309aed675155d5f302ab7f / Xinyuan Lin <[email protected]> chore(amber): remove the unused EditingTimeCompilationRequest (#8397) ### What changes were proposed in this PR? Deletes `EditingTimeCompilationRequest`, a websocket request the frontend no longer sends and the backend no longer handles. Pure deletion, no behaviour change: **−39 lines** across the case class, its `@JsonSubTypes` registration, the protocol spec's entries, and the frontend type-map entry. ### History | | | | --- | --- | | **Introduced by** | #2195 (2023-11-09) — "Enhance frontend error reporting", which had the editor send the logical plan over the websocket to collect static errors | | **Usage removed by** | #3178 (2024-12-29) — "Remove cache checker in logical plan" deleted the handler that took it, when compilation moved to the HTTP `workflow-compiling-service` | Dead for about a year and a half, with no sender and no handler since. The frontend documents the switch itself, in `workflow-compiling.service.ts`: > receive static errors (previously done by sending `EditingTimeCompilationRequest` and saving in the `ExecutionStateInfo`) > Reviewer note: that comment is **kept** — it is accurate history explaining why the service works the way it does, and it is the only remaining mention of the name. The shared `emptyPlanFields` test fixture also stays: `WorkflowExecuteRequest`'s `logicalPlan` still uses it. Its doc comment and the spec's list of registered type ids are updated to match. ### Any related issues, documentation, discussions? Closes #8394 ### How was this PR tested? Existing tests only — this PR adds none; it narrows the protocol spec to the types that remain registered. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile"` — success. - `sbt "WorkflowExecutionService/testOnly *TexeraWebSocketRequestSpec"` — 12 tests, all pass. - `sbt scalafmtCheckAll "scalafixAll --check"` — clean. >From `frontend/`: - `yarn --cwd frontend format:ci` — clean (this PR touches a `.ts` file). Verification, re-runnable by a reviewer: ``` git grep -n EditingTimeCompilationRequest # only the historical comment remains ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) Report URL: https://github.com/apache/texera/actions/runs/36095117063 With regards, GitHub Actions via GitBox
