The GitHub Actions job "Backport Approval Check" on texera.git/fix/stale-save-response has failed. Run started by GitHub user Copilot (triggered by Copilot).
Head commit for run: 81ee927322b18b24a8c8beb85ad64a1220023253 / Yang Zhang <[email protected]> fix(workflow): drop the Form View's own copy of the local-name rule Review follow-up on #8540: with WorkflowPersistService relaying every response with the page's current name and description, the form's persist handler was enforcing the same rule a second time. By the time it ran, the response already carried the current name, so both branches of its guard produced the same value. Keeping both meant two statements of one rule, and the caller-side one was the narrower of the two: name only, keyed off the snapshot the save was sent with. It never covered description, so a reader trusting it would have concluded the description was protected too, and a later change to withLocalEdits could have reintroduced exactly the bug this PR fixes. The spec that pinned the caller-side guard goes with it. It drove the persist service through a double, so it never exercised withLocalEdits at all and only described behaviour the component no longer owns. The rule itself stays covered where it now lives, in workflow-persist.service.spec, and the form's remaining obligation -- feeding the response back so "Saved at ..." advances -- is still covered by "feeds the persist response back into the workflow metadata". Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01FVvP3ttj22f9LB4p9u2anY Report URL: https://github.com/apache/texera/actions/runs/35935704536 With regards, GitHub Actions via GitBox
