The GitHub Actions job "Backport Approval Check" on texera.git/fix-8315-shared-nonshared-state has succeeded. Run started by GitHub user yangzhang75 (triggered by yangzhang75).
Head commit for run: aabcbe7630843381065ca0bfadd70bf29f8cc903 / Yang Zhang <[email protected]> fix(workflow): give the room precedence over a document's first seed only, and end a seed's listening with it Review follow-up on #8351, second round. The room's value won over every seed of a key for as long as the document lived, which was meant for the open and reached every later reload into the same document too: a version shown (the provider disconnected, the graph reloaded) or returned from, an agent's rewrite. Their settings and form definition stayed the current ones while the graph showed the version, and a revert then stored that mix. The precedence is now for the first seed of a key on a document; a later reload's seed replaces what the document holds, the room's value included, or clears it for a version that carries none. A seed that waited for the sync registered a once-listener that nothing removed when the seed was superseded or cancelled, so a document that never synced collected one per reload. Each seed now owns its listener and detaches it when it lands, is superseded, or is cancelled. The per-document seed state (waiting copies, seeds, room ownership, seeded keys) is reset in one place, when a new document is loaded, which is also what keeps the previous workflow's waiting copy out of a blank one; the blank reload no longer seeds anything itself. Spec: a later reload replaces and then clears a value the room owned; one sync listener per waiting key, none once superseded, cancelled or landed. The sync helper now sets the provider's synced flag, as the provider does, so a later reload's seed goes in at once as it would live. Co-Authored-By: Claude Fable 5.1 <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/36369383036 With regards, GitHub Actions via GitBox
