This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-8815-3ae15e6428442ae77ed8b113392f122d746a87b5 in repository https://gitbox.apache.org/repos/asf/texera.git
commit 28dbb8885713f3f92d1c1e2114d57f2d1a8e4a75 Author: Xinyuan Lin <[email protected]> AuthorDate: Fri Oct 2 20:46:44 2026 +0000 refactor(amber): remove the unused cache.ccf (#8815) ### What changes were proposed in this PR? Deletes `amber/src/main/resources/cache.ccf`, an Apache Commons JCS cache configuration that nothing loads. **−29 lines.** There is no behaviour change. The `commons-jcs3-core` dependency stays, because `ComputingUnitMaster` / `ComputingUnitWorker` still import its `InvalidArgumentException`. JCS never names this file in code: it loads `/cache.ccf` from the classpath implicitly, when the cache manager creates its first region. So the check for this PR is whether anything can create a JCS cache, not whether the file name appears anywhere. Nothing can: - **Source:** the only JCS class referenced in any module is `InvalidArgumentException`. Nothing calls `JCS.getInstance`, `CacheAccess`, `CompositeCacheManager` or `JCSWorker`. - **Bytecode:** after compiling amber and the common modules, the compiled classes reference the same single exception class and no other JCS class. - **Dependencies:** no other jar on amber's runtime or test classpath references JCS. `InvalidArgumentException` is a plain `RuntimeException` subclass with no static initializer, so throwing it never reaches the cache manager. ### History | | | | --- | --- | | **Introduced by** | #1328 (2021-09-08), "[Operator Caching Step 3] add operator cache backend new files and config changes", for `JCSOpResultStorage`'s `JCS.getInstance("texera")` | | **Usage removed by** | #1363 (2022-01-25), "Sink operator result storage abstraction and refactoring". It deleted `JCSOpResultStorage`, the only code that ever created a JCS cache | It has been dead for over four and a half years. ### Any related issues, documentation, discussions? Closes #8814 ### How was this PR tested? No new tests; this deletes a resource file that nothing loads. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile"`: success. To re-check: ``` git grep -n -i "cache\.ccf\|JCS\.getInstance\|CompositeCacheManager" # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- amber/src/main/resources/cache.ccf | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/amber/src/main/resources/cache.ccf b/amber/src/main/resources/cache.ccf deleted file mode 100644 index b03d869250..0000000000 --- a/amber/src/main/resources/cache.ccf +++ /dev/null @@ -1,29 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -# DEFAULT CACHE REGION - -jcs.default=DC -jcs.default.cacheattributes=org.apache.commons.jcs3.engine.CompositeCacheAttributes -jcs.default.cacheattributes.MaxObjects=10 -jcs.default.cacheattributes.MemoryCacheName=org.apache.commons.jcs3.engine.memory.lru.LRUMemoryCache -jcs.default.elementattributes.IsSpool=true - -jcs.auxiliary.DC=org.apache.commons.jcs3.auxiliary.disk.indexed.IndexedDiskCacheFactory -jcs.auxiliary.DC.attributes=org.apache.commons.jcs3.auxiliary.disk.indexed.IndexedDiskCacheAttributes -jcs.auxiliary.DC.attributes.DiskPath=/tmp/disk_cache -jcs.auxiliary.DC.attributes.MaxKeySize=0 \ No newline at end of file
