This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-8829-b05b6206c031ebb1cd4fb7b5f1f318a28f5c51f7 in repository https://gitbox.apache.org/repos/asf/texera.git
commit 2082021a8073c26bc38aeac7d654bdc661d4ff87 Author: Xinyuan Lin <[email protected]> AuthorDate: Sat Oct 3 23:42:05 2026 +0000 refactor(frontend): remove the unreachable agent panel shadow (#8829) ### What changes were proposed in this PR? Removes a class binding in `AgentPanelComponent` that can never apply. **+1/−11 lines.** There is no behaviour change. `<ul id="return-button">` has `[ngClass]="{'shadow': !width}"` and `*ngIf="width"` on the **same element**. `*ngIf` creates the element only while `width` is truthy, and `!width` is then always `false`. So `shadow` is never set on a rendered element. `width` is a `number` that is only ever 0, the 400px minimum, a resize width, or a range-checked stored width, so there is no value that is both truthy and falsy. The PR removes: - the binding; - the `.shadow` rule, which nothing else in this component's template uses (the styles are encapsulated); - `NgClass` from the imports, because this was the template's only `ngClass`. The `*ngIf` and every live style on the element stay. ### History | | | | --- | --- | | **Introduced by** | #4020 (2025-11-25), "feat: introduce the LLM-based workflow copilot": the binding, the `*ngIf` and the `.shadow` rule together. #4873 (2026-05-03) later added the `NgClass` import when the component became standalone | | **Usage removed by** | **never used**. The binding has been unreachable since the line was written. #4495 only moved the files | It has never applied, in the ten months since it was added. ### Any related issues, documentation, discussions? Closes #8828 ### How was this PR tested? No new tests; no spec referenced the class. From `frontend/`: - `npx ng test --watch=false --include='**/agent-panel.component.spec.ts' --include='**/workspace.component.spec.ts'`: 2 files, 86 tests, all pass. These are the only specs that render the panel. - `yarn format:ci`: clean. - `npx ng build`: success. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- .../component/agent/agent-panel/agent-panel.component.html | 1 - .../component/agent/agent-panel/agent-panel.component.scss | 8 -------- .../component/agent/agent-panel/agent-panel.component.ts | 3 +-- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.html b/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.html index ee77072aa0..ee0aeb8764 100644 --- a/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.html +++ b/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.html @@ -53,7 +53,6 @@ <ul id="return-button" nz-menu - [ngClass]="{'shadow': !width}" *ngIf="width"> <li nz-menu-item diff --git a/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.scss b/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.scss index 776ec393f0..80c3ec719d 100644 --- a/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.scss +++ b/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.scss @@ -70,14 +70,6 @@ overflow-y: auto; } -.shadow { - border-radius: 5px; - box-shadow: - 0 3px 1px -2px #0003, - 0 2px 2px #00000024, - 0 1px 5px #0000001f; -} - .ant-menu-item { margin: 0 !important; height: 32px; diff --git a/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.ts b/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.ts index deb652f44f..7d4a498dc4 100644 --- a/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.ts +++ b/frontend/src/app/workspace/component/agent/agent-panel/agent-panel.component.ts @@ -24,7 +24,7 @@ import { AgentService, AgentInfo } from "../../../service/agent/agent.service"; import { WorkflowActionService } from "../../../service/workflow-graph/model/workflow-action.service"; import { NotificationService } from "../../../../common/service/notification/notification.service"; import { calculateTotalTranslate3d } from "../../../../common/util/panel-dock"; -import { NgIf, NgClass, NgFor } from "@angular/common"; +import { NgIf, NgFor } from "@angular/common"; import { NzSpaceCompactItemDirective } from "ng-zorro-antd/space"; import { NzButtonComponent } from "ng-zorro-antd/button"; import { NzWaveDirective } from "ng-zorro-antd/core/wave"; @@ -53,7 +53,6 @@ import { AgentChatComponent } from "./agent-chat/agent-chat.component"; CdkDrag, NzResizableDirective, NzMenuDirective, - NgClass, NzMenuItemComponent, CdkDragHandle, NzTabsComponent,
