The GitHub Actions job "Backport Approval Check" on 
texera.git/fix/form-huggingface-task-persists has failed.
Run started by GitHub user yangzhang75 (triggered by yangzhang75).

Head commit for run:
5b7424e445c0935222ba11538c02fb05786381cd / Yang Zhang <[email protected]>
fix(workflow-form): let a card change its operator's siblings the way the panel 
does, so the HuggingFace task change persists on the form

An exposed HuggingFace model picker on the Form View offered a task
selector that could not persist: the card wrote back only the property
it was bound to, under the binding's id, and the operator's other
properties were a read-only copy with no controls. Changing the task on
the form switched the model list but saved nothing, so a reader could
pick a model for a task the operator does not run.

The Form View is another way to show the canvas, so a card now behaves
like the operator property panel for the property it exposes. The field
keeps the property's own key; the operator's other properties ride
along as plain controls on the card's form and in its model, so a
widget that reads or writes a sibling by key (the HuggingFace picker
writes task and resets the task-scoped fields) finds the same controls
as on the panel; and the card writes back everything that differs from
the operator in one edit (FormBindingService.writeProperties), the
bound property and the siblings a widget changed. An empty string and
an absent property count as the same value, so formly's blank for a
property the operator never had is not written on every build.

Two more things the two views needed to agree, found with both open on
one workflow: the form held every rebuild while a closed dropdown kept
the focus (its search box counted as typing), so a change made on the
canvas never showed until the reader clicked elsewhere -- a dropdown is
typing only while its list is open; and the HuggingFace selector on the
canvas kept showing the task it was built with when the form (or a
co-editor) changed it -- it now follows its field's model on every
check, as a local pick is followed (the panel hides the schema's task
field, so there is no control to listen to).

Closes #8762

Co-Authored-By: Claude Fable 5.1 <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/37182292022

With regards,
GitHub Actions via GitBox

Reply via email to