The GitHub Actions job "Required Checks" on 
texera.git/feat/form-projection-drag-reorder has succeeded.
Run started by GitHub user yangzhang75 (triggered by yangzhang75).

Head commit for run:
60053dc46223e23a8edc70ec543cec74e2ecdace / Yang Zhang <[email protected]>
feat(workflow-form): render Projection's drag-reorder list in the form, with 
the drag

An exposed drag-reorder property (Projection's columns, formly type
repeat-section-dnd) fell back to a plain repeated list in the Form View:
the rows could be edited but not reordered. The fallback assumed the
drag had nowhere to attach on a form; the widget carries its own drop
list, and the row template comes from the operator schema the form
already builds. Take it out of CANVAS_ONLY_FORMLY_TYPES, which now
holds the code editor only. The widget renders on the form exactly as
on the operator property panel; the panel's reorder callback stays
optional, since the card's form persists a drop through valueChanges.

Two defects of the widget itself, in reach of the form for the first
time: its buttons carried no type, so inside a form (the card's, the
panel's) Enter in a row's input clicked the first one and removed a
row; and the rows kept their build-time keys after a drop, so a value
typed into a moved row landed on the row that used to be there (formly
keys rows by position and writes by that key path, re-keying on its own
remove(); a drop now re-keys the same way).

Closes #8761

Co-Authored-By: Claude Fable 5.1 <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/37235382797

With regards,
GitHub Actions via GitBox

Reply via email to