The GitHub Actions job "Backport Approval Check" on texera.git/fix/form-udf-parameters-overrides has failed. Run started by GitHub user yangzhang75 (triggered by yangzhang75).
Head commit for run: 49e5528dbacf1af86e7ff4022fe891f438a972ba / Yang Zhang <[email protected]> fix(workflow-form): let ui-udf-parameters show the form's renames and hides, and add a parameter to the card's operator The ui-udf-parameters widget hides formly's labels and draws fixed column headers (Value / Name / Type), so the author's per-sub-field overrides from the Form View changed nothing a reader saw: a renamed column kept its old name and a hidden one kept its header over an empty cell. On a Form View card the widget now decides which columns are in view from the first row's sub-fields (a hidden column, or one whose group is hidden, is left out, header and cells alike), read live, since the form's hide lands on a row after formly has built it; the header shows the author's name for the column, else the panel's fixed label. The Form View names the operator on every field it renders (props.operatorID, FIELD_OPERATOR_ID_PROP / fieldOperatorID), since nothing is highlighted on the form; the same mark tells a shared widget which host it is on. Add parameter uses it: it inserts a declaration into an operator's code, and it took that operator from the canvas highlight, so on the form it edited the wrong operator or failed. It now adds to the field's operator on a card, and to the highlighted one on the panel. The declared parameters then reach the operator: the panel's frame writes them only for the operator it shows while it acts as the editor, so the form writes them when the frame does not (a writer only, the operator still on the graph). A reader's value cells stay locked: the Form View marks a reader's field props.disabled, and the widget's own "the value is editable" used to re-enable the control after formly had disabled it. And the widget's own lock on the Name and Type cells (inferred from the code; a name typed there no longer matches a declaration) now holds under any host: the panel enables its whole form group when it turns interactive, and formly mirrors a control's state into props.disabled, so a one-time disable did not survive on the canvas while the form showed the cells locked. The widget holds a locked cell through the control's disabled-change hook, which disables it again whenever a host enables it; a cell configured editable is released. Closes #8763 Co-Authored-By: Claude Fable 5.1 <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/37262140646 With regards, GitHub Actions via GitBox
