The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-8744-82ab13483dff640e580850d6f534964ae2d68029 has failed. Run started by GitHub user kunwp1 (triggered by kunwp1).
Head commit for run: 0fc6e789aa1298e19f3428101c5fd069c5309fa4 / Xinyuan Lin <[email protected]> refactor(workflow-core, pyamber): remove unused removeOne (#8744) ### What changes were proposed in this PR? Removes `removeOne` / `remove_one` from the buffered-writer API in both languages. No production code calls it. **−64 lines.** There is no behaviour change. - **Scala:** the `BufferedItemWriter.removeOne` trait method, the `IcebergTableWriter` override, the no-op override in `OutputPortStorageWriterThreadSpec`'s `StubWriter`, and the `IcebergTableWriterSpec` case that called it. - **pyamber:** the abstract `BufferedItemWriter.remove_one`, the `IcebergTableWriter` implementation, and its two tests. ### History | | | | --- | --- | | **Introduced by** | #2681 (2024-06-05), "Add MongoDocument and MemoryDocument": the Scala trait method. #3147 (2025-01-08): the Iceberg override. #3224 (2025-01-30), "Add Storage Layer In Python": the pyamber copy | | **Usage removed by** | #3295 (2025-03-09), "Use Output Ports of an Operator to Write Storage". It commented out the last live call, `writer.removeOne(tupleValue)` in the progressive sink's set-snapshot retraction branch, and #3312 later deleted the commented line. The pyamber method was **never used** | It has been dead for eighteen months. Every remaining call is in a test. ### Any related issues, documentation, discussions? Closes #8743 ### How was this PR tested? No new tests. The writer specs keep their cases for the surviving API. Locally, with Java 17: - `sbt "WorkflowCore/Test/compile" "WorkflowCore/testOnly *IcebergTableWriterSpec"`: 4 tests, all pass. - `sbt "WorkflowExecutionService/Test/compile" "WorkflowExecutionService/testOnly *OutputPortStorageWriterThreadSpec"`: 6 tests, all pass. - `sbt "WorkflowCore/scalafmtCheckAll" "WorkflowCore/scalafixAll --check" "WorkflowExecutionService/scalafmtCheckAll" "WorkflowExecutionService/scalafixAll --check"`: clean. >From `amber/`: - `python -m pytest -m "not integration" src/test/python/core/storage/iceberg/test_iceberg_table_writer.py`: 12 tests, all pass. - `ruff check src/main/python src/test/python && ruff format --check src/main/python src/test/python`: clean. To re-check: ``` git grep -n -i -E "remove_?one" # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Report URL: https://github.com/apache/texera/actions/runs/37376273672 With regards, GitHub Actions via GitBox
