This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-8748-e2e0225263bf5400b5f6d2d6c99475b9e836cc04 in repository https://gitbox.apache.org/repos/asf/texera.git
commit d69d740f2492cddf5826ac4279b328185c245455 Author: Xinyuan Lin <[email protected]> AuthorDate: Mon Oct 5 22:14:40 2026 +0000 refactor(frontend): remove dead hub workflow detail markup (#8748) ### What changes were proposed in this PR? Removes three leftovers from `HubWorkflowDetailComponent`. **−24 lines.** There is no behaviour change. - **Template:** the empty `<ng-template #codeEditor></ng-template>`. Nothing reads it: the component has no `@ViewChild`, and the only other `#codeEditor` in the app is the live one in `workspace.component.html`. - **Styles:** the `.workflow-steps`, `.workflow-step`, `.workflow-step h3` and `.workflow-step p` rules, which no markup uses. - **Styles:** the `body` rule. Under the default emulated encapsulation Angular compiles it to `body[_ngcontent-…]`, and the document `<body>` (static in `index.html`) never carries that attribute, so it matches nothing. ### History | | | | --- | --- | | **Introduced by** | #2725 (2024-09-24), "Add Hub": the step styles and the `body` rule. #2873 (2024-09-27), "Add workflow preview to hub details page": the `#codeEditor` anchor | | **Usage removed by** | #3006 (2024-11-05), "Remove home page and step from the detail page": the step markup. #3007 (2024-11-05), "Fix sharing issue of hub preview": the `@ViewChild("codeEditor")` that read the anchor. The `body` rule never matched anything | The step styles and the anchor have been dead for nearly two years. The `body` rule never took effect. ### Any related issues, documentation, discussions? Closes #8747 ### How was this PR tested? No new tests. From `frontend/`: - `npx ng test --watch=false --include='**/hub-workflow-detail.component.spec.ts' --include='**/card-item.component.spec.ts' --include='**/list-item.component.spec.ts' --include='**/workspace.component.spec.ts'`: 4 files, 221 tests, all pass. The card-item and list-item specs open this component in a modal, and the workspace spec owns the live `#codeEditor`. - `yarn format:ci`: clean. - `npx ng build`: success. - After also removing the `body` rule: the hub-workflow-detail, card-item and list-item specs pass (3 files, 186 tests), and `prettier --check` on the stylesheet is clean. To re-check: ``` git grep -n "workflow-step" -- frontend # no hits grep -n "^body" frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.scss # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <[email protected]> --- .../detail/hub-workflow-detail.component.html | 1 - .../detail/hub-workflow-detail.component.scss | 23 ---------------------- 2 files changed, 24 deletions(-) diff --git a/frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.html b/frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.html index d3c41ab3c9..940fb54cbd 100644 --- a/frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.html +++ b/frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.html @@ -115,6 +115,5 @@ <texera-workflow-editor></texera-workflow-editor> <texera-mini-map class="box"></texera-mini-map> </div> - <ng-template #codeEditor></ng-template> </div> </div> diff --git a/frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.scss b/frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.scss index ca505cd1d7..642761e795 100644 --- a/frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.scss +++ b/frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.scss @@ -17,13 +17,6 @@ * under the License. */ -body { - font-family: Arial, sans-serif; - margin: 0; - padding: 0; - background-color: #f4f4f4; -} - .container { width: 80%; margin: 30px auto 0; @@ -48,22 +41,6 @@ h1 { .workflow-info div:last-child { margin-right: 0; } -.workflow-steps { - margin-top: 20px; -} -.workflow-step { - background-color: #f9f9f9; - padding: 15px; - margin-bottom: 10px; - border-left: 5px solid #007bff; -} -.workflow-step h3 { - margin: 0; - color: #007bff; -} -.workflow-step p { - margin: 5px 0; -} .preview-containers { position: relative;
