The GitHub Actions job "Comment commands" on texera.git/main has succeeded. Run started by GitHub user ShawnGarello (triggered by ShawnGarello).
Head commit for run: 22b82a2958f8328be2f05044092e2b30e38c56cb / Om Kashyap Avashia <[email protected]> refactor(frontend): drop unused generated protobuf TypeScript (#9020) ### What changes were proposed in this PR? `bin/frontend-proto-gen.sh` runs `protoc` on `workflow.proto` and `virtualidentity.proto`, but ts-proto also writes TypeScript for their transitive imports. Those imports are used only for ScalaPB options (`scalapb.options`, `scalapb.field`), which shape the Scala output and produce no TypeScript types. As a result, two files nothing uses were generated and committed: | File | Lines | Imported by | | --- | --- | --- | | `proto/google/protobuf/descriptor.ts` | 6824 | `scalapb.ts` only | | `proto/scalapb/scalapb.ts` | 2394 | nothing | Changes: | File | Change | | --- | --- | | `bin/frontend-proto-gen.sh` | Removes `proto/scalapb` and `proto/google` after `protoc` runs, so the files don't come back on the next regeneration | | `frontend/src/app/common/type/proto/{google,scalapb}/` | Deleted | | `LICENSE` | Removes the `descriptor.ts` entry and the `scalapb.ts` line. The `scalapb.proto` entry stays because that file is still in the repo | | `.licenserc.yaml` | Removes the license-check exclusions for the two deleted files | ``` Before: protoc -> workflow.ts, virtualidentity.ts, scalapb.ts, descriptor.ts (committed, unused) After: protoc -> workflow.ts, virtualidentity.ts ``` User-facing behavior is unchanged. ### Any related issues, documentation, discussions? Closes #9012 Follows #9010, which added the `LICENSE` entries for these generated files. ### How was this PR tested? - `bash bin/frontend-proto-gen.sh`: the output folder contains only `org/apache/texera/amber/core/{virtualidentity,workflow}.ts` - `cd frontend && yarn build`: succeeds - `cd frontend && yarn test`: 237 test files passed; 6649 tests passed, 1 skipped No tests added: this removes dead generated code and nothing imports it. ### Was this PR authored or co-authored using generative AI tooling? Co-authored by Claude-Code (helped with file and code deletion, navigating repo, writing this PR description, and tests) Report URL: https://github.com/apache/texera/actions/runs/39463509508 With regards, GitHub Actions via GitBox
