This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-8926-22b82a2958f8328be2f05044092e2b30e38c56cb in repository https://gitbox.apache.org/repos/asf/texera.git
commit 3ba45ee5a5f641388d1a9eda90afa26a62d70d30 Author: Xinyuan Lin <[email protected]> AuthorDate: Wed Oct 21 05:28:38 2026 +0000 refactor(frontend): remove dead pve-modal selectors (#8926) ### What changes were proposed in this PR? Removes two selectors from the global stylesheet's Python-environment modal (`.pve-modal`) block that match no element. **+1/−8 lines.** There is no behaviour change. - **The `.pve-modal .system-header .subtitle` rule.** The only `.system-header` element (in the computing-unit selection modal) contains just a `.title`. No template, TS code or ng-zorro component produces a bare `subtitle` class. - **The bare `.package-inputs` token in `.package-header-row, .package-inputs`.** The rule and `.package-header-row` stay. The templates use `system-package-inputs` and `user-package-inputs`, and CSS matches whole class tokens, so neither matches `.package-inputs`. Because these are global styles, the check covered every template and TS file in the app, plus ng-zorro's compiled output. ### History | | | | --- | --- | | **Introduced by** | #4484 (2026-05-01), "feat: Add Python Virtual Environment Support: Creating a Virtual Environment", which added the whole `.pve-modal` block | | **Usage removed by** | #4902 (2026-05-12), "Installing User Defined Packages", renamed the element to `system-package-inputs`, which left `.package-inputs` unmatched. `.subtitle` was **never used** | `.package-inputs` has been dead for nearly five months. ### Any related issues, documentation, discussions? Closes #8925 ### How was this PR tested? No new tests; no spec referenced either selector. From `frontend/`: - `npx ng test --watch=false --include='**/user-venv.component.spec.ts' --include='**/computing-unit-selection.component.spec.ts'`: 2 files, 242 tests, all pass. These are the only specs that render the modal. - `yarn format:ci`: clean. - `npx ng build`: success. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- frontend/src/styles.scss | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/frontend/src/styles.scss b/frontend/src/styles.scss index 3625505f95..731ae2dcef 100644 --- a/frontend/src/styles.scss +++ b/frontend/src/styles.scss @@ -202,8 +202,7 @@ hr { font-style: italic; } - .package-header-row, - .package-inputs { + .package-header-row { display: grid; grid-template-columns: 1fr 1fr; gap: 12px; @@ -446,11 +445,5 @@ hr { .title { font-weight: 500; } - - .subtitle { - font-size: 12px; - color: #8c8c8c; - margin-top: 2px; - } } }
