This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-9071-3ef665a233cb56832746a184122101fbd985d592 in repository https://gitbox.apache.org/repos/asf/texera.git
commit c34c45ac422957b062490e5bb7bb7d02324ee160 Author: Xinyuan Lin <[email protected]> AuthorDate: Wed Oct 21 07:23:24 2026 +0000 refactor(frontend): remove the unused GenericWebResponse types (#9071) ### What changes were proposed in this PR? Deletes `frontend/src/app/common/type/generic-web-response.ts`, a type file nothing imports. **−32 lines.** There is no behaviour change. The file exports `GenericWebResponse` and `GenericWebResponseCode`. No code, spec, barrel file or path alias references the file or either symbol, and no open PR adds an import. ### History | | | | --- | --- | | **Introduced by** | #752 (2020-05-15), "User System Frontend Part": the interface. #757 (2020-06-05), "User System Dictionary Uploading", added the enum | | **Usage removed by** | #1470 (2022-05-19), "Change Login component to use ng-zorro instead of bootstrap. Remove unused components". It removed the last readers | It has been unused for over four years. ### Any related issues, documentation, discussions? Closes #9068 ### How was this PR tested? No new tests; nothing referenced the file. From `frontend/`: - `npx tsc --noEmit -p src/tsconfig.app.json` and `npx tsc --noEmit -p src/tsconfig.spec.json`: clean. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -i -e GenericWebResponse -e generic-web-response # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- .../src/app/common/type/generic-web-response.ts | 32 ---------------------- 1 file changed, 32 deletions(-) diff --git a/frontend/src/app/common/type/generic-web-response.ts b/frontend/src/app/common/type/generic-web-response.ts deleted file mode 100644 index c354b10e9b..0000000000 --- a/frontend/src/app/common/type/generic-web-response.ts +++ /dev/null @@ -1,32 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -/** - * Do not use `const enum` here. Const enums are inlined at compile time and removed - * from the emitted JavaScript, which causes runtime errors if the enum is accessed dynamically. - */ -export enum GenericWebResponseCode { - SUCCESS = 0, -} - -export interface GenericWebResponse - extends Readonly<{ - code: GenericWebResponseCode; - message: string; - }> {}
