The GitHub Actions job "Backport Approval Check" on 
texera.git/feat/form-view-switch-without-reload has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
338e95cd7f6e8d1c09b5aabf31c14fa077960229 / Yang Zhang <[email protected]>
fix(frontend): give a handed-over view the rest of the run, not just its state

Three more from the Copilot review on #8581, all the same shape as the
ones before them: the hand-over retains the execution, and each view
rebuilt only part of its picture of it.

- The computing-unit selector asks the backend whether an execution is
  running, and its answer arrives after whatever the arriving page set.
  The query covers only Running and Initializing, so a handed-over
  Paused, Pausing, Recovering or Resuming run answered "none" and the
  selector unlocked the graph, undoing the lock the page had just been
  given. It defers to `reapplyExecutionLock` now, so "no execution
  someone else started" no longer means "nothing is running here".

- The run clock is a websocket event the backend sends only when the
  run's start or end time changes, so a view created mid-run counted
  from zero until the run ended. `ExecuteWorkflowService` holds the last
  duration now, and both the menu and the Form View read it when they
  mount -- the menu had the same hole on a resumed canvas, which the
  review found on the Form View side.

- Restoring the state enum alone left the Form View's failure banner
  off: no transition follows a hand-over, so the subscriber that raises
  it never ran, and the form showed nothing while the canvas it came
  from showed the failure. The banner logic moved into
  `showFailureIfAny`, called from the subscriber as before and once on
  arrival, after the fields exist -- it asks them whether a required one
  was left empty.

Deletion-checked: restoring the selector's unconditional unlock, or
dropping either of the form's two reads, each turns exactly the intended
named test red. The selector's existing tests did not catch it, because
with nothing running the two spellings behave alike; the new test is the
case that differs.

Full frontend suite: 224 files, 6161 passed, 1 skipped, 0 failed. AOT
build, eslint and prettier clean.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01FVvP3ttj22f9LB4p9u2anY

Report URL: https://github.com/apache/texera/actions/runs/35645375569

With regards,
GitHub Actions via GitBox

Reply via email to