Author: roger
Date: Fri Mar 4 13:35:05 2011
New Revision: 1077939
URL: http://svn.apache.org/viewvc?rev=1077939&view=rev
Log:
THRIFT-1084 Typo fixes
Patch: Bruce Mitchener
Modified:
thrift/trunk/NEWS
thrift/trunk/README.SSL
thrift/trunk/doc/thrift.tex
thrift/trunk/lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java
thrift/trunk/lib/java/src/org/apache/thrift/protocol/TProtocolUtil.java
thrift/trunk/lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java
thrift/trunk/lib/java/src/org/apache/thrift/server/TNonblockingServer.java
thrift/trunk/lib/java/src/org/apache/thrift/transport/TFileTransport.java
thrift/trunk/lib/java/src/org/apache/thrift/transport/TFramedTransport.java
thrift/trunk/lib/java/src/org/apache/thrift/transport/THttpClient.java
thrift/trunk/lib/java/src/org/apache/thrift/transport/TMemoryBuffer.java
thrift/trunk/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java
thrift/trunk/lib/java/src/org/apache/thrift/transport/TSaslTransport.java
thrift/trunk/lib/java/src/org/apache/thrift/transport/TServerSocket.java
thrift/trunk/lib/java/src/org/apache/thrift/transport/TTransport.java
thrift/trunk/lib/java/test/org/apache/thrift/transport/TestTSaslTransports.java
thrift/trunk/tutorial/java/src/JavaClient.java
Modified: thrift/trunk/NEWS
URL:
http://svn.apache.org/viewvc/thrift/trunk/NEWS?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/NEWS (original)
+++ thrift/trunk/NEWS Fri Mar 4 13:35:05 2011
@@ -1,8 +1,8 @@
Release Notes for Thrift 20080411
-.equals and .hashCode() for Java scturcts (developed by dreiss).
+.equals and .hashCode() for Java structs (developed by dreiss).
-Improvments to the C++ TSocketPool (developed by akhil).
+Improvements to the C++ TSocketPool (developed by akhil).
PHP (de)serialization extension (developed by dweatherford).
Modified: thrift/trunk/README.SSL
URL:
http://svn.apache.org/viewvc/thrift/trunk/README.SSL?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/README.SSL (original)
+++ thrift/trunk/README.SSL Fri Mar 4 13:35:05 2011
@@ -31,12 +31,12 @@ Author: Ping Li <pin...@facebook.com>
factory->loadPrivateKey("my-private-key.pem");
// server: optionally setup access manager
// shared_ptr<AccessManager> accessManager(new MyAccessManager);
- // factory->access(acessManager);
+ // factory->access(accessManager);
...
}
// client code sample
- shared_ptr<TSSLSocketFactory> factory = getSSLScoketFactory();
+ shared_ptr<TSSLSocketFactory> factory = getSSLSocketFactory();
shared_ptr<TSocket> socket = factory.createSocket(host, port);
shared_ptr<TBufferedTransport> transport(new TBufferedTransport(socket));
...
@@ -57,7 +57,7 @@ Author: Ping Li <pin...@facebook.com>
After SSL handshake completes, additional checks are conducted. Application
is given the chance to decide whether or not to continue the conversation
- with the remote. Application is inqueried through the above three "verify"
+ with the remote. Application is queried through the above three "verify"
method. They are called at different points of the verification process.
Decisions can be one of ALLOW, DENY, and SKIP. ALLOW and DENY means the
@@ -74,7 +74,7 @@ Author: Ping Li <pin...@facebook.com>
field is extracted, (c) is called.
The "host" in (b) is the value from TSocket::getHost() if this is a client
- side socket, or TScoket::getPeerHost() if this is a server side socket. The
+ side socket, or TSocket::getPeerHost() if this is a server side socket. The
reason is client side socket initiates the connection. TSocket::getHost()
is the remote host name. On server side, the remote host name is unknown
unless it's retrieved through TSocket::getPeerHost(). Either way, "host"
@@ -132,4 +132,4 @@ Author: Ping Li <pin...@facebook.com>
OpenSSL's RAND_poll() when OpenSSL library is first initialized.
The PRNG seed is key to the application security. This method should be
- overriden if it's not strong enough for you.
+ overridden if it's not strong enough for you.
Modified: thrift/trunk/doc/thrift.tex
URL:
http://svn.apache.org/viewvc/thrift/trunk/doc/thrift.tex?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/doc/thrift.tex (original)
+++ thrift/trunk/doc/thrift.tex Fri Mar 4 13:35:05 2011
@@ -151,7 +151,7 @@ how to safely transport the objects acro
The type system rests upon a few base types. In considering which types to
support, we aimed for clarity and simplicity over abundance, focusing
-on the key types available in all programming languages, ommitting any
+on the key types available in all programming languages, omitting any
niche types available only in specific languages.
The base types supported by Thrift are:
@@ -299,8 +299,8 @@ socket, a segment of shared memory, or a
transport interface supports the following methods:
\begin{itemize}
-\item \texttt{open} Opens the tranpsort
-\item \texttt{close} Closes the tranport
+\item \texttt{open} Opens the transport
+\item \texttt{close} Closes the transport
\item \texttt{isOpen} Indicates whether the transport is open
\item \texttt{read} Reads from the transport
\item \texttt{write} Writes to the transport
@@ -345,7 +345,7 @@ post-processing or for reproduction and/
\subsubsection{Utilities}
The Transport interface is designed to support easy extension using common
-OOP techniques, such as composition. Some simple utilites include the
+OOP techniques, such as composition. Some simple utilities include the
\texttt{TBufferedTransport}, which buffers the writes and reads on an
underlying transport, the \texttt{TFramedTransport}, which transmits data with
frame
size headers for chunking optimization or nonblocking operation, and the
@@ -873,7 +873,7 @@ possible that our thread create call,
\texttt{ThreadFactory::newThread()} could return to the caller
well before that time. To ensure that the returned \texttt{Thread} object is
not
prematurely cleaned up if the caller gives up its reference prior to the
-\texttt{ThreadMain} call, the \texttt{Thread} object makes a weak referenence
to
+\texttt{ThreadMain} call, the \texttt{Thread} object makes a weak reference to
itself in its \texttt{start} method.
With the weak reference in hand the \texttt{ThreadMain} function can attempt
to get
@@ -1023,7 +1023,7 @@ described:
XML parsing overhead.
\item \textit{CORBA.} Relatively comprehensive, debatably overdesigned and
heavyweight. Comparably cumbersome software installation.
-\item \textit{COM.} Embraced mainly in Windows client softare. Not an entirely
+\item \textit{COM.} Embraced mainly in Windows client software. Not an entirely
open solution.
\item \textit{Pillar.} Lightweight and high-performance, but missing versioning
and abstraction.
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java
Fri Mar 4 13:35:05 2011
@@ -291,7 +291,7 @@ public final class TCompactProtocol exte
}
/**
- * Write a string to the wire with a varint size preceeding.
+ * Write a string to the wire with a varint size preceding.
*/
public void writeString(String str) throws TException {
try {
@@ -415,7 +415,7 @@ public final class TCompactProtocol exte
}
/**
- * Writes a byte without any possiblity of all that field header nonsense.
+ * Writes a byte without any possibility of all that field header nonsense.
* Used internally by other writing methods that know they need to write a
byte.
*/
private byte[] byteDirectBuffer = new byte[1];
@@ -425,7 +425,7 @@ public final class TCompactProtocol exte
}
/**
- * Writes a byte without any possiblity of all that field header nonsense.
+ * Writes a byte without any possibility of all that field header nonsense.
*/
private void writeByteDirect(int n) throws TException {
writeByteDirect((byte)n);
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/protocol/TProtocolUtil.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/protocol/TProtocolUtil.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/protocol/TProtocolUtil.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/protocol/TProtocolUtil.java Fri
Mar 4 13:35:05 2011
@@ -53,7 +53,7 @@ public class TProtocolUtil {
* Skips over the next data element from the provided input TProtocol object.
*
* @param prot the protocol object to read from
- * @param type the next value will be intepreted as this TType value.
+ * @param type the next value will be interpreted as this TType value.
*/
public static void skip(TProtocol prot, byte type)
throws TException {
@@ -64,7 +64,7 @@ public class TProtocolUtil {
* Skips over the next data element from the provided input TProtocol object.
*
* @param prot the protocol object to read from
- * @param type the next value will be intepreted as this TType value.
+ * @param type the next value will be interpreted as this TType value.
* @param maxDepth this function will only skip complex objects to this
* recursive depth, to prevent Java stack overflow.
*/
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
---
thrift/trunk/lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java
(original)
+++
thrift/trunk/lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java
Fri Mar 4 13:35:05 2011
@@ -264,7 +264,7 @@ public class TSimpleJSONProtocol extends
escape.append('t');
break;
default:
- // Control characeters! According to JSON RFC u0020 (space)
+ // Control characters! According to JSON RFC u0020 (space)
if (c < ' ') {
String hex = Integer.toHexString(c);
escape.append('\\');
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/server/TNonblockingServer.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/server/TNonblockingServer.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/server/TNonblockingServer.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/server/TNonblockingServer.java
Fri Mar 4 13:35:05 2011
@@ -136,7 +136,7 @@ public class TNonblockingServer extends
}
/**
- * Stop listening for conections.
+ * Stop listening for connections.
*/
protected void stopListening() {
serverTransport_.close();
@@ -273,7 +273,7 @@ public class TNonblockingServer extends
* Select and process IO events appropriately:
* If there are connections to be accepted, accept them.
* If there are existing connections with data waiting to be read, read it,
- * bufferring until a whole frame has been read.
+ * buffering until a whole frame has been read.
* If there are any pending responses, buffer them until their target
client
* is available, and then send the data.
*/
@@ -397,7 +397,7 @@ public class TNonblockingServer extends
* Class that implements a sort of state machine around the interaction with
* a client and an invoker. It manages reading the frame size and frame data,
* getting it handed off as wrapped transports, and then the writing of
- * reponse data back to the client. In the process it manages flipping the
+ * response data back to the client. In the process it manages flipping the
* read and write bits on the selection key for its client.
*/
protected class FrameBuffer {
@@ -483,7 +483,7 @@ public class TNonblockingServer extends
return true;
}
- // incremement the amount of memory allocated to read buffers
+ // increment the amount of memory allocated to read buffers
readBufferBytesAllocated += frameSize;
// reallocate the readbuffer as a frame-sized buffer
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/transport/TFileTransport.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/transport/TFileTransport.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/transport/TFileTransport.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/transport/TFileTransport.java
Fri Mar 4 13:35:05 2011
@@ -451,7 +451,7 @@ public class TFileTransport extends TTra
/**
- * Reads up to len bytes into buffer buf, starting att offset off.
+ * Reads up to len bytes into buffer buf, starting at offset off.
*
* @param buf Array to read into
* @param off Index to start reading at
@@ -515,7 +515,7 @@ public class TFileTransport extends TTra
chunk += numChunks;
}
- // too large a value for reverse seek, just seek to beginnin
+ // too large a value for reverse seek, just seek to beginning
if (chunk < 0) {
chunk = 0;
}
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/transport/TFramedTransport.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/transport/TFramedTransport.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/transport/TFramedTransport.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/transport/TFramedTransport.java
Fri Mar 4 13:35:05 2011
@@ -23,7 +23,7 @@ import org.apache.thrift.TByteArrayOutpu
/**
* TFramedTransport is a buffered TTransport that ensures a fully read message
- * every time by preceeding messages with a 4-byte frame size.
+ * every time by preceding messages with a 4-byte frame size.
*/
public class TFramedTransport extends TTransport {
@@ -65,7 +65,7 @@ public class TFramedTransport extends TT
}
/**
- * Constructor wraps around another tranpsort
+ * Constructor wraps around another transport
*/
public TFramedTransport(TTransport transport, int maxLength) {
transport_ = transport;
Modified: thrift/trunk/lib/java/src/org/apache/thrift/transport/THttpClient.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/transport/THttpClient.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/transport/THttpClient.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/transport/THttpClient.java Fri
Mar 4 13:35:05 2011
@@ -240,7 +240,7 @@ public class THttpClient extends TTransp
// Read the responses into a byte array so we can release the connection
// early. This implies that the whole content will have to be read in
- // memory, and that momentarly we might use up twice the memory (while
the
+ // memory, and that momentarily we might use up twice the memory (while
the
// thrift struct is being read up the chain).
// Proceeding differently might lead to exhaustion of connections and
thus
// to app failure.
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/transport/TMemoryBuffer.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/transport/TMemoryBuffer.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/transport/TMemoryBuffer.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/transport/TMemoryBuffer.java
Fri Mar 4 13:35:05 2011
@@ -28,7 +28,7 @@ import java.io.UnsupportedEncodingExcept
public class TMemoryBuffer extends TTransport {
/**
* Create a TMemoryBuffer with an initial buffer size of <i>size</i>. The
- * internal buffer will grow as necessary to accomodate the size of the data
+ * internal buffer will grow as necessary to accommodate the size of the data
* being written to it.
*/
public TMemoryBuffer(int size) {
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
---
thrift/trunk/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java
(original)
+++
thrift/trunk/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java
Fri Mar 4 13:35:05 2011
@@ -45,7 +45,7 @@ public class TNonblockingServerSocket ex
private ServerSocketChannel serverSocketChannel = null;
/**
- * Underlying serversocket object
+ * Underlying ServerSocket object
*/
private ServerSocket serverSocket_ = null;
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/transport/TSaslTransport.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSaslTransport.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/transport/TSaslTransport.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/transport/TSaslTransport.java
Fri Mar 4 13:35:05 2011
@@ -200,7 +200,7 @@ abstract class TSaslTransport extends TT
}
/**
- * Send a Thrift SASL message with the given status (usaully BAD or ERROR)
and
+ * Send a Thrift SASL message with the given status (usually BAD or ERROR)
and
* string message, and then throw a TTransportException with the given
* message.
*
@@ -235,7 +235,7 @@ abstract class TSaslTransport extends TT
/**
* Opens the underlying transport if it's not already open and then performs
- * SASL negotiation. If a QOP is negoiated during this SASL handshake, it
used
+ * SASL negotiation. If a QOP is negotiated during this SASL handshake, it
used
* for all communication on this transport after this call is complete.
*/
@Override
Modified:
thrift/trunk/lib/java/src/org/apache/thrift/transport/TServerSocket.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/transport/TServerSocket.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/transport/TServerSocket.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/transport/TServerSocket.java
Fri Mar 4 13:35:05 2011
@@ -37,7 +37,7 @@ public class TServerSocket extends TServ
private static final Logger LOGGER =
LoggerFactory.getLogger(TServerSocket.class.getName());
/**
- * Underlying serversocket object
+ * Underlying ServerSocket object
*/
private ServerSocket serverSocket_ = null;
Modified: thrift/trunk/lib/java/src/org/apache/thrift/transport/TTransport.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/src/org/apache/thrift/transport/TTransport.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/lib/java/src/org/apache/thrift/transport/TTransport.java
(original)
+++ thrift/trunk/lib/java/src/org/apache/thrift/transport/TTransport.java Fri
Mar 4 13:35:05 2011
@@ -56,7 +56,7 @@ public abstract class TTransport {
public abstract void close();
/**
- * Reads up to len bytes into buffer buf, starting att offset off.
+ * Reads up to len bytes into buffer buf, starting at offset off.
*
* @param buf Array to read into
* @param off Index to start reading at
Modified:
thrift/trunk/lib/java/test/org/apache/thrift/transport/TestTSaslTransports.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/lib/java/test/org/apache/thrift/transport/TestTSaslTransports.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
---
thrift/trunk/lib/java/test/org/apache/thrift/transport/TestTSaslTransports.java
(original)
+++
thrift/trunk/lib/java/test/org/apache/thrift/transport/TestTSaslTransports.java
Fri Mar 4 13:35:05 2011
@@ -313,7 +313,7 @@ public class TestTSaslTransports extends
/**
* Implementation of SASL ANONYMOUS, used for testing client-side
- * intial responses.
+ * initial responses.
*/
private static class AnonymousClient implements SaslClient {
private final String username;
Modified: thrift/trunk/tutorial/java/src/JavaClient.java
URL:
http://svn.apache.org/viewvc/thrift/trunk/tutorial/java/src/JavaClient.java?rev=1077939&r1=1077938&r2=1077939&view=diff
==============================================================================
--- thrift/trunk/tutorial/java/src/JavaClient.java (original)
+++ thrift/trunk/tutorial/java/src/JavaClient.java Fri Mar 4 13:35:05 2011
@@ -45,7 +45,7 @@ public class JavaClient {
}
else {
/*
- * Similar to the server, you can use the parametrs to setup client
parameters or
+ * Similar to the server, you can use the parameters to setup client
parameters or
* use the default settings. On the client side, you will need a
TrustStore which
* contains the trusted certificate along with the public key.
* For this example it's a self-signed cert.
