This is an automated email from the ASF dual-hosted git repository. tballison pushed a commit to branch TIKA-4809-stage-9 in repository https://gitbox.apache.org/repos/asf/tika.git
commit 279315924c4cdb98b7533ea299c9840c8c8d8062 Author: tallison <[email protected]> AuthorDate: Tue Aug 11 08:31:24 2026 -0400 TIKA-4809: Correct testFetcherNotFound, which asserted the bug it was named for --- .../java/org/apache/tika/pipes/core/PipesClientTest.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/PipesClientTest.java b/tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/PipesClientTest.java index 09bfbfaccc..b7e6582565 100644 --- a/tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/PipesClientTest.java +++ b/tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/PipesClientTest.java @@ -560,12 +560,15 @@ public class PipesClientTest { PipesResult pipesResult = pipesClient.process(tuple); - assertEquals(PipesResult.RESULT_STATUS.FETCHER_INITIALIZATION_EXCEPTION, pipesResult.status(), - "Should return FETCHER_INITIALIZATION_EXCEPTION when fetcher name is invalid"); + // An unknown fetcher id is not an initialization failure: nothing failed to start, + // the caller named something this server does not have. FetchHandler used to catch + // IllegalArgumentException, which FetcherManager never throws, so this fell through + // to the initialization branch and FETCHER_NOT_FOUND was unreachable. + assertEquals(PipesResult.RESULT_STATUS.FETCHER_NOT_FOUND, pipesResult.status(), + "Should return FETCHER_NOT_FOUND when fetcher name is invalid"); - // Verify it's categorized as INITIALIZATION_FAILURE - assertTrue(pipesResult.isInitializationFailure(), - "FETCHER_INITIALIZATION_EXCEPTION should be initialization failure category"); + assertTrue(pipesResult.isTaskException(), + "FETCHER_NOT_FOUND is a task exception, not an initialization failure"); // Verify error message mentions the fetcher name Assertions.assertNotNull(pipesResult.message());
