a test failed in TinkerGraphNoStrategyComputerIntegrateTest. It must have been wrong for a long time but we just got 'thread lucky.' FilterRankStrategy is required or else the ordering goes bad after dedup().
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/1ae137f6 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/1ae137f6 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/1ae137f6 Branch: refs/heads/TINKERPOP-1278 Commit: 1ae137f67d8abf854877b7d016bca3c672d13454 Parents: b63332f Author: Marko A. Rodriguez <okramma...@gmail.com> Authored: Sat Jul 9 07:25:41 2016 -0600 Committer: Marko A. Rodriguez <okramma...@gmail.com> Committed: Sat Jul 9 07:25:41 2016 -0600 ---------------------------------------------------------------------- .../apache/tinkerpop/gremlin/process/traversal/util/PathUtil.java | 2 +- .../tinkergraph/process/TinkerGraphNoStrategyComputerProvider.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/1ae137f6/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/PathUtil.java ---------------------------------------------------------------------- diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/PathUtil.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/PathUtil.java index e621d00..dcf1dfc 100644 --- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/PathUtil.java +++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/PathUtil.java @@ -49,7 +49,7 @@ public class PathUtil { public static Set<String> getReferencedLabels(final Step step) { final Set<String> referencedLabels = new HashSet<>(); - if (step instanceof Parameterizing) { + if (step instanceof Parameterizing) { // TODO: we should really make the mutation steps Scoping :| final Parameters parameters = ((Parameterizing) step).getParameters(); for (final Traversal.Admin trav : parameters.getTraversals()) { for (final Object ss : trav.getSteps()) { http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/1ae137f6/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/process/TinkerGraphNoStrategyComputerProvider.java ---------------------------------------------------------------------- diff --git a/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/process/TinkerGraphNoStrategyComputerProvider.java b/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/process/TinkerGraphNoStrategyComputerProvider.java index 3199627..50ba5d4 100644 --- a/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/process/TinkerGraphNoStrategyComputerProvider.java +++ b/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/process/TinkerGraphNoStrategyComputerProvider.java @@ -24,6 +24,7 @@ import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSo import org.apache.tinkerpop.gremlin.process.traversal.strategy.decoration.ConnectiveStrategy; import org.apache.tinkerpop.gremlin.process.traversal.strategy.decoration.SideEffectStrategy; import org.apache.tinkerpop.gremlin.process.traversal.strategy.finalization.ProfileStrategy; +import org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.FilterRankingStrategy; import org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.RangeByIsCountStrategy; import org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.ComputerVerificationStrategy; import org.apache.tinkerpop.gremlin.structure.Graph; @@ -43,6 +44,7 @@ public class TinkerGraphNoStrategyComputerProvider extends TinkerGraphComputerPr RangeByIsCountStrategy.class, ComputerVerificationStrategy.class, ProfileStrategy.class, + FilterRankingStrategy.class, ConnectiveStrategy.class, SideEffectStrategy.class));
