Repository: tinkerpop Updated Branches: refs/heads/TINKERPOP-1520 515574149 -> 73859cce8
TINKERPOP-1520 Print seed to the logging in test using Random This pattern could probably be generalized to other tests that use Random (where removing Random doesn't make sense). That will be saved for another ticket. Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/73859cce Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/73859cce Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/73859cce Branch: refs/heads/TINKERPOP-1520 Commit: 73859cce8563c3951e39fef58b189acb9718e5c3 Parents: 5155741 Author: Stephen Mallette <[email protected]> Authored: Thu Nov 24 06:34:15 2016 -0500 Committer: Stephen Mallette <[email protected]> Committed: Thu Nov 24 06:34:15 2016 -0500 ---------------------------------------------------------------------- .../traversal/dsl/graph/GraphTraversalTest.java | 14 ++++++++++---- .../src/test/resources/log4j-silent.properties | 5 ++++- gremlin-core/src/test/resources/log4j-test.properties | 5 ++++- 3 files changed, 18 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/73859cce/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalTest.java ---------------------------------------------------------------------- diff --git a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalTest.java b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalTest.java index 2c3c6c1..cfa63fa 100644 --- a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalTest.java +++ b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalTest.java @@ -23,6 +23,8 @@ import org.apache.tinkerpop.gremlin.process.traversal.P; import org.apache.tinkerpop.gremlin.process.traversal.Scope; import org.apache.tinkerpop.gremlin.process.traversal.Traversal; import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.lang.reflect.Method; import java.util.ArrayList; @@ -38,13 +40,14 @@ import static org.junit.Assert.assertEquals; * @author Marko A. Rodriguez (http://markorodriguez.com) */ public class GraphTraversalTest { + private static final Logger logger = LoggerFactory.getLogger(GraphTraversalTest.class); private static Set<String> NO_GRAPH = new HashSet<>(Arrays.asList("asAdmin", "by", "option", "iterate", "to", "from", "profile", "pageRank", "peerPressure", "program")); private static Set<String> NO_ANONYMOUS = new HashSet<>(Arrays.asList("start", "__")); private static Set<String> IGNORES_BYTECODE = new HashSet<>(Arrays.asList("asAdmin", "iterate", "mapValues", "mapKeys")); @Test - public void anonymousGraphTraversalShouldHaveMethodsOfGraphTraversal() { + public void shouldHaveMethodsOfGraphTraversalOnAnonymousGraphTraversal() { for (Method methodA : GraphTraversal.class.getMethods()) { if (Traversal.class.isAssignableFrom(methodA.getReturnType()) && !NO_GRAPH.contains(methodA.getName())) { boolean found = false; @@ -63,7 +66,7 @@ public class GraphTraversalTest { } @Test - public void graphTraversalShouldHaveMethodsOfAnonymousGraphTraversal() { + public void shouldHaveMethodsOfAnonymousGraphTraversalOnGraphTraversal() { for (Method methodA : __.class.getMethods()) { if (Traversal.class.isAssignableFrom(methodA.getReturnType()) && !NO_ANONYMOUS.contains(methodA.getName())) { boolean found = false; @@ -82,8 +85,11 @@ public class GraphTraversalTest { } @Test - public void graphTraversalMethodsShouldGenerateCorrespondingBytecode() throws Exception { - final Random random = new Random(); + public void shouldGenerateCorrespondingBytecodeFromGraphTraversalMethods() throws Exception { + final long seed = System.currentTimeMillis(); + final Random random = new Random(seed); + logger.info("***RANDOM*** GraphTraversalTest.shouldGenerateCorrespondingBytecodeFromGraphTraversalMethods - seed is {}", seed); + for (Method stepMethod : GraphTraversal.class.getMethods()) { if (Traversal.class.isAssignableFrom(stepMethod.getReturnType()) && !IGNORES_BYTECODE.contains(stepMethod.getName())) { final GraphTraversal.Admin<?, ?> traversal = new DefaultGraphTraversal<>(); http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/73859cce/gremlin-core/src/test/resources/log4j-silent.properties ---------------------------------------------------------------------- diff --git a/gremlin-core/src/test/resources/log4j-silent.properties b/gremlin-core/src/test/resources/log4j-silent.properties index 1825bb0..e43797f 100644 --- a/gremlin-core/src/test/resources/log4j-silent.properties +++ b/gremlin-core/src/test/resources/log4j-silent.properties @@ -20,4 +20,7 @@ log4j.rootLogger=OFF, stdout log4j.appender.stdout=org.apache.log4j.ConsoleAppender log4j.appender.stdout.layout=org.apache.log4j.PatternLayout -log4j.appender.stdout.layout.ConversionPattern=[%p] %C - %m%n \ No newline at end of file +log4j.appender.stdout.layout.ConversionPattern=[%p] %C - %m%n + +# need to turn this on as this test uses Random and needs INFO to display the seed used +log4j.logger.org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalTest=INFO \ No newline at end of file http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/73859cce/gremlin-core/src/test/resources/log4j-test.properties ---------------------------------------------------------------------- diff --git a/gremlin-core/src/test/resources/log4j-test.properties b/gremlin-core/src/test/resources/log4j-test.properties index ef436fe..3cb3d4f 100644 --- a/gremlin-core/src/test/resources/log4j-test.properties +++ b/gremlin-core/src/test/resources/log4j-test.properties @@ -18,4 +18,7 @@ log4j.rootLogger=WARN, stdout log4j.appender.stdout=org.apache.log4j.ConsoleAppender log4j.appender.stdout.layout=org.apache.log4j.PatternLayout -log4j.appender.stdout.layout.ConversionPattern=[%p] %C - %m%n \ No newline at end of file +log4j.appender.stdout.layout.ConversionPattern=[%p] %C - %m%n + +# need to turn this on as this test uses Random and needs INFO to display the seed used +log4j.logger.org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalTest=INFO \ No newline at end of file
