spmallette commented on issue #1070: TINKERPOP-2143 JavaScript GLV: Support browsers URL: https://github.com/apache/tinkerpop/pull/1070#issuecomment-466988053 @fdominik Travis seems to be complaining about something: ```text [INFO] --- frontend-maven-plugin:1.6:npm (npm test) @ gremlin-javascript --- [INFO] Running 'npm test --exit' in /home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript [INFO] [INFO] > gremlin@3.4.1-alpha1 test /home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript [INFO] > mocha test/unit test/integration -t 5000 [INFO] [ERROR] module.js:471 [ERROR] throw err; [ERROR] ^ [ERROR] [ERROR] Error: Cannot find module 'uuid/v4' [ERROR] at Function.Module._resolveFilename (module.js:469:15) [ERROR] at Function.Module._load (module.js:417:25) [ERROR] at Module.require (module.js:497:17) [ERROR] at require (internal/module.js:20:19) [ERROR] at Object.<anonymous> (/home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js:26:16) [ERROR] at Module._compile (module.js:570:32) [ERROR] at Object.Module._extensions..js (module.js:579:10) [ERROR] at Module.load (module.js:487:32) [ERROR] at tryModuleLoad (module.js:446:12) [ERROR] at Function.Module._load (module.js:438:3) [ERROR] at Module.require (module.js:497:17) [ERROR] at require (internal/module.js:20:19) [ERROR] at Object.<anonymous> (/home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal.js:25:15) [ERROR] at Module._compile (module.js:570:32) [ERROR] at Object.Module._extensions..js (module.js:579:10) [ERROR] at Module.load (module.js:487:32) [ERROR] at tryModuleLoad (module.js:446:12) [ERROR] at Function.Module._load (module.js:438:3) [ERROR] at Module.require (module.js:497:17) [ERROR] at require (internal/module.js:20:19) [ERROR] at Object.<anonymous> (/home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/index.js:25:11) [ERROR] at Module._compile (module.js:570:32) [ERROR] at Object.Module._extensions..js (module.js:579:10) [ERROR] at Module.load (module.js:487:32) [ERROR] at tryModuleLoad (module.js:446:12) [ERROR] at Function.Module._load (module.js:438:3) [ERROR] at Module.require (module.js:497:17) [ERROR] at require (internal/module.js:20:19) [ERROR] at Object.<anonymous> (/home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/exports-test.js:26:19) [ERROR] at Module._compile (module.js:570:32) [ERROR] at Object.Module._extensions..js (module.js:579:10) [ERROR] at Module.load (module.js:487:32) [ERROR] at tryModuleLoad (module.js:446:12) [ERROR] at Function.Module._load (module.js:438:3) [ERROR] at Module.require (module.js:497:17) [ERROR] at require (internal/module.js:20:19) [ERROR] at /home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/node_modules/mocha/lib/mocha.js:231:27 [ERROR] at Array.forEach (native) [ERROR] at Mocha.loadFiles (/home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/node_modules/mocha/lib/mocha.js:228:14) [ERROR] at Mocha.run (/home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/node_modules/mocha/lib/mocha.js:514:10) [ERROR] at Object.<anonymous> (/home/travis/build/apache/tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/node_modules/mocha/bin/_mocha:484:18) [ERROR] at Module._compile (module.js:570:32) [ERROR] at Object.Module._extensions..js (module.js:579:10) [ERROR] at Module.load (module.js:487:32) [ERROR] at tryModuleLoad (module.js:446:12) [ERROR] at Function.Module._load (module.js:438:3) [ERROR] at Module.runMain (module.js:604:10) [ERROR] at run (bootstrap_node.js:383:7) [ERROR] at startup (bootstrap_node.js:149:9) [ERROR] at bootstrap_node.js:496:3 [ERROR] npm ERR! Test failed. See above for more details. ``` Failed on two separate builds which is interesting because I wasn't aware javascript builds were running twice. @jorgebay it seems like we don't use the `.glv` file to control whether or not `gremlin-javascript` builds. I think that's fine given that the maven plugin seems to handle all the environmental setup on the local machine. Any reason we need a [specific build](https://github.com/apache/tinkerpop/blob/master/.travis.yml#L35) for `gremlin-javascript` then? seems like we could just rely on the regular `mvn clean install` build, right?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
