spmallette commented on issue #1127: TINKERPOP-2241 URL: https://github.com/apache/tinkerpop/pull/1127#issuecomment-500991981 Thanks for the fix. I think that this change makes sense. Could you please clean up the commit history a bit though? You have two commits on this pull request when one would be enough (just rebase/squash). When you rebase, could you please target the `tp33` branch as I think the problem goes all the way back to the 3.3.x line of code. Once that's done I think that we can get it merged. Also, if you want to make this pull request fully complete, please add a [CHANGELOG entry](https://github.com/apache/tinkerpop/blob/7a18d92b018050324417f56fe3481a6797539df1/CHANGELOG.asciidoc#tinkerpop-338-release-date-not-officially-released-yet) - i can handle it myself though when i merge if you like. VOTE +1 (note to other reviewers who might come along, i will probably merge this small change via CTR)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
