This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch TINKERPOP-2309 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit f0cd4e93df279798693bdf6b8df3f496f36245dc Author: stephen <[email protected]> AuthorDate: Thu Oct 31 09:52:11 2019 -0400 TINKERPOP-2309 Bump to Tornado 5.x Removed a test that started failing after the version bump. I assume it no longer is necessary given that the error is "Cannot run the event loop while another loop is running" and I've taken to mean that since asyncio is automatically use when available the test is no longer relevant. --- CHANGELOG.asciidoc | 1 + gremlin-python/src/main/jython/setup.py | 2 +- .../jython/tests/driver/test_driver_remote_connection.py | 15 --------------- 3 files changed, 2 insertions(+), 16 deletions(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index cb270f1..a74d84f 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -23,6 +23,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima [[release-3-3-10]] === TinkerPop 3.3.10 (Release Date: NOT OFFICIALLY RELEASED YET) +* Bump to Tornado 5.x for gremlin-python. [[release-3-3-9]] === TinkerPop 3.3.9 (Release Date: October 14, 2019) diff --git a/gremlin-python/src/main/jython/setup.py b/gremlin-python/src/main/jython/setup.py index f99ef62..ff328b5 100644 --- a/gremlin-python/src/main/jython/setup.py +++ b/gremlin-python/src/main/jython/setup.py @@ -46,7 +46,7 @@ version = __version__.version install_requires = [ 'aenum>=1.4.5', - 'tornado>=4.4.1,<5.0', + 'tornado>=5.1.1,<6.0', 'six>=1.10.0', 'isodate>=0.6.0' ] diff --git a/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py b/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py index cc721e8..1d5c0f5 100644 --- a/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py +++ b/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py @@ -295,18 +295,3 @@ class TestDriverRemoteConnection(object): assert results results = t.side_effects.close() assert not results - - -def test_in_tornado_app(remote_connection): - # Make sure nothing weird with loops - @gen.coroutine - def go(): - conn = DriverRemoteConnection( - 'ws://localhost:45940/gremlin', 'gmodern', pool_size=4) - g = traversal().withRemote(conn) - yield gen.sleep(0) - assert len(g.V().toList()) == 6 - conn.close() - - io_loop = ioloop.IOLoop.current() - io_loop.run_sync(go)
