jroimartin commented on code in PR #1700: URL: https://github.com/apache/tinkerpop/pull/1700#discussion_r904033476
########## gremlin-go/driver/connection_test.go: ########## @@ -1121,4 +1121,26 @@ func TestConnection(t *testing.T) { // This routine. assert.Equal(t, startCount, runtime.NumGoroutine()) }) + + t.Run("Test per-request arguments", func(t *testing.T) { + skipTestsIfNotEnabled(t, integrationTestSuiteName, testNoAuthEnable) + + g := getTestGraph(t, testNoAuthUrl, testNoAuthAuthInfo, testNoAuthTlsConfig) + defer g.remoteConnection.Close() + + _, err := g.With("evaluationTimeout", 10).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next() + assert.NotNil(t, err) + + _, err = g.With("evaluationTimeout", 10000).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next() + assert.Nil(t, err) + + _, err = g.With("evaluationTimeout", 10000).With("evaluationTimeout", 10).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next() + assert.NotNil(t, err) + + _, err = g.WithStrategies(OptionsStrategy(map[string]interface{}{"evaluationTimeout": 10})).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next() + assert.NotNil(t, err) + + _, err = g.WithStrategies(OptionsStrategy(map[string]interface{}{"evaluationTimeout": 10000})).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next() + assert.Nil(t, err) + }) Review Comment: Done in 30f9702. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org