tkolanko commented on code in PR #1837:
URL: https://github.com/apache/tinkerpop/pull/1837#discussion_r1014906005
##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java:
##########
@@ -231,9 +233,18 @@ protected void evalOpInternal(final Context ctx, final
Supplier<GremlinExecutor>
final GremlinExecutor.LifeCycle lifeCycle =
GremlinExecutor.LifeCycle.build()
.evaluationTimeoutOverride(seto)
.afterFailure((b,t) -> {
+ graphManager.onQueryError(msg, t);
if (managedTransactionsForRequest) attemptRollback(msg,
ctx.getGraphManager(), settings.strictTransactionManagement);
})
+ .afterTimeout(b -> {
Review Comment:
@spmallette In
https://github.com/apache/tinkerpop/pull/1837/commits/718c0830d0725655b8c5999832e12f917991a9fc
I deprecated the use of `afterTimeout` as a consumer and I had the deprecated
method create a new `BiConsumer` which calls the updated `afterTimeout` method.
I also reverted the `GremlinExecutor` tests to use the deprecated method to
make sure they are still working, I can either move them to the new method or
leave things as they are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
