vkagamlyk commented on code in PR #2127:
URL: https://github.com/apache/tinkerpop/pull/2127#discussion_r1258776061
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -2554,21 +2557,30 @@ public default GraphTraversal<S, E> property(final
VertexProperty.Cardinality ca
*/
public default GraphTraversal<S, E> property(final Object key, final
Object value, final Object... keyValues) {
if (key instanceof VertexProperty.Cardinality) {
- if (value instanceof Map) { //Handle the property(Cardinality,
Map) signature
- final Map<Object, Object> map = (Map)value;
+ if (value instanceof Map) {
+ // Handle the property(Cardinality, Map) signature
+ final Map<Object, Object> map = (Map) value;
for (Map.Entry<Object, Object> entry : map.entrySet()) {
- property(key, entry.getKey(), entry.getValue());
+ final Object val = entry.getValue();
+ if (val instanceof CardinalityValueTraversal) {
+ final CardinalityValueTraversal cardVal =
(CardinalityValueTraversal) val;
+ property(cardVal.getCardinality(), entry.getKey(),
cardVal.getValue());
+ } else {
+ property(key, entry.getKey(), entry.getValue());
Review Comment:
probably recursive call is not safe here
```
gremlin> g.V(1).property(list, [["k1":"v1", "k2":"v2"]:"value"])
==>v[1]
gremlin> g.V(1).valueMap()
==>[k1:[v1],k2:[v2],name:[marko],age:[29]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
