xiazcy commented on code in PR #2232:
URL: https://github.com/apache/tinkerpop/pull/2232#discussion_r1327589315


##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -1437,6 +1440,66 @@ public default GraphTraversal<S, String> concat(final 
String... concatStrings) {
         return this.asAdmin().addStep(new ConcatStep<>(this.asAdmin(), 
concatStrings));
     }
 
+    /**
+     * Returns a string with the specified characters in the original string 
replaced with the new characters.
+     * Null values are not processed and remain as null when returned. If the 
incoming traverser is a non-String
+     * value then an {@code IllegalArgumentException} will be thrown.
+     *
+     * @return the traversal with an appended {@link ReplaceStep}.
+     * @see <a 
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#replace-step";
 target="_blank">Reference Documentation - Replace Step</a>
+     * @since 3.7.1
+     */
+    public default GraphTraversal<S, String> replace(final String oldChar, 
final String newChar) {
+        this.asAdmin().getBytecode().addStep(Symbols.replace, oldChar, 
newChar);
+        return this.asAdmin().addStep(new ReplaceStep<>(this.asAdmin(), 
oldChar, newChar));
+    }
+
+    /**
+     * Returns a list of strings created by splitting the incoming string 
traverser around the matches of the given delimiter.
+     * Null values are not processed and remain as null when returned. If the 
incoming traverser is a non-String
+     * value then an {@code IllegalArgumentException} will be thrown.
+     *
+     * @return the traversal with an appended {@link SplitStep}.
+     * @see <a 
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#split-step";
 target="_blank">Reference Documentation - Split Step</a>
+     * @since 3.7.1
+     */
+    public default GraphTraversal<S, List<String>> split(final String 
splitChar) {

Review Comment:
   Updated to `separator`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to