tien commented on PR #2506:
URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972293541

   @vkagamlyk the proper way would be to actually run the unit tests in the 
browser, like @kmcginnes mentioned.
   
   But that could potentially be a huge change to the current test suite.
   
   Another way would be to inject a browser `WebSocket` polyfill into the 
current test suite using `jsdom`. It's not perfect but would require a lot less 
changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to