tien commented on code in PR #2515: URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522535064
########## gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts: ########## @@ -46,43 +44,49 @@ class Graph { } class Element { - constructor(id, label) { - this.id = id; - this.label = label; - } + constructor( + readonly id: string, + readonly label: string, + ) {} /** * Compares this instance to another and determines if they can be considered as equal. * @param {Element} other * @returns {boolean} */ - equals(other) { + equals(other: Element) { Review Comment: Yes, this make sense, I've updated accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org