FlorianHockmann commented on code in PR #2610:
URL: https://github.com/apache/tinkerpop/pull/2610#discussion_r1608258129
##########
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/EdgeDeserializer.cs:
##########
@@ -31,26 +31,26 @@ internal class EdgeDeserializer : IGraphSONDeserializer
public dynamic Objectify(JsonElement graphsonObject, GraphSONReader
reader)
{
var outVId = reader.ToObject(graphsonObject.GetProperty("outV"));
- var outVLabel = graphsonObject.TryGetProperty("outVLabel", out var
outVLabelProperty)
- ? outVLabelProperty.GetString()
+ string outVLabel = graphsonObject.TryGetProperty("outVLabel", out
var outVLabelProperty)
Review Comment:
(nitpick) The change from `var` to `string` shouldn't be necessary and I'd
like to avoid that. With the added `!` behind `GetString()`, my IDE already
shows that `outVLabel` is of type `string` if I keep `var` here.
(The same applies to the other places in this diff of course.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
