spmallette commented on code in PR #2779:
URL: https://github.com/apache/tinkerpop/pull/2779#discussion_r1764893356
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/binary/types/BigDecimalSerializer.java:
##########
@@ -36,7 +36,7 @@ public BigDecimalSerializer() {
}
@Override
- protected BigDecimal readValue(final Buffer buffer, final
GraphBinaryReader context) throws IOException {
+ protected BigDecimal readValue(final Buffer buffer, final
GraphBinaryReader context, byte valueFlag) throws IOException {
Review Comment:
`valueFlag` should be `final` - please review all use of `final` in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
