vkagamlyk commented on code in PR #2992:
URL: https://github.com/apache/tinkerpop/pull/2992#discussion_r1929602092
##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransaction.java:
##########
@@ -203,7 +203,7 @@ protected void doCommit() throws TransactionException {
final Set<TinkerElementContainer> readElements =
txReadElements.get();
if (readElements != null)
- readElements.stream().forEach(e -> e.reset());
+ readElements.stream().forEach(e -> e.commit(txVersion));
Review Comment:
Thanks Cole for figuring this out!
I think it would be good to add a test to verify case when element is in
both `changedVertices` and `readElements`, that `usedInTransactions` counter
will be reduced exactly 2 times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
